Re: [PR] apache#15162 - Bug Fix Segments going into BAD state for Dedup Tables with metadataTTL [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15178: URL: https://github.com/apache/pinot/pull/15178#issuecomment-2696469308 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15178?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] apache#15162 - Bug Fix Segments going into BAD state for Dedup Tables with metadataTTL [pinot]

2025-03-03 Thread via GitHub
deepthi912 opened a new pull request, #15178: URL: https://github.com/apache/pinot/pull/15178 **Context:** https://apache-pinot.slack.com/archives/C011C9JHN7R/p1740757158048619 Noticed segments going into BAD state when metadataTTL is set for dedup tables and Replication > 1 `[R

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978448778 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadZKClient.java: ## @@ -0,0 +1,187 @@ +/** + * Licensed to the Apache Software Foundation (A

Re: [PR] Changes to support parallel test runs [pinot]

2025-03-03 Thread via GitHub
krishan1390 commented on code in PR #15170: URL: https://github.com/apache/pinot/pull/15170#discussion_r1978622237 ## pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java: ## @@ -141,7 +142,7 @@ public static List buildServerAdminConfigs(PinotConfiguratio

Re: [PR] Add assertions to QueryRoutingTest [pinot]

2025-03-03 Thread via GitHub
yashmayya commented on code in PR #15165: URL: https://github.com/apache/pinot/pull/15165#discussion_r1978603209 ## pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java: ## @@ -54,6 +54,7 @@ import static org.testng.Assert.assertNotNull; import static

Re: [PR] Eliminate object type check during aggregate ser/de [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15176: URL: https://github.com/apache/pinot/pull/15176#issuecomment-2696153105 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15176?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978426979 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadMetrics.java: ## @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Software Foundation (ASF

(pinot) branch master updated: Improve minion observer stats to capture more granular stages of minion task execution (#15118)

2025-03-03 Thread manishswaminathan
This is an automated email from the ASF dual-hosted git repository. manishswaminathan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 862a931667 Improve minion observer sta

Re: [PR] Improve minion observer stats to capture more granular stages of minion task execution [pinot]

2025-03-03 Thread via GitHub
swaminathanmanish merged PR #15118: URL: https://github.com/apache/pinot/pull/15118 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@

[PR] Change Pre-filter logic in MergeRollup task [pinot]

2025-03-03 Thread via GitHub
kate-yq opened a new pull request, #15177: URL: https://github.com/apache/pinot/pull/15177 # Change Pre-filter logic in MergeRollup task This PR solves [issue 15128](https://github.com/apache/pinot/issues/15128) `bugfix` -- This is an automated message from the Apache

(pinot) branch master updated: Make ser/de part of the AggregationFunction (#15158)

2025-03-03 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new df6cef135b Make ser/de part of the AggregationFun

Re: [PR] Make ser/de part of the AggregationFunction [pinot]

2025-03-03 Thread via GitHub
Jackie-Jiang merged PR #15158: URL: https://github.com/apache/pinot/pull/15158 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Make ser/de part of the AggregationFunction [pinot]

2025-03-03 Thread via GitHub
Jackie-Jiang commented on code in PR #15158: URL: https://github.com/apache/pinot/pull/15158#discussion_r1978492421 ## pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java: ## @@ -84,15 +95,36 @@ public static RowDataBlock buildFromRows(List row

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
J-HowHuang commented on code in PR #15175: URL: https://github.com/apache/pinot/pull/15175#discussion_r1978418056 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -963,6 +974,15 @@ private Pair getInstancePartitionsF

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978444329 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadTableInfo.java: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978448108 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadZKClient.java: ## @@ -0,0 +1,187 @@ +/** + * Licensed to the Apache Software Foundation (A

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978444790 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadTableInfo.java: ## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978436532 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,430 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978440695 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadStatusRecorder.java: ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add minimizeDataMovement to Rebalacne API [pinot]

2025-03-03 Thread via GitHub
Jackie-Jiang commented on code in PR #15110: URL: https://github.com/apache/pinot/pull/15110#discussion_r1978439542 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/instance/InstanceAssignmentDriver.java: ## @@ -55,40 +55,64 @@ public InstanceA

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978439175 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadStatusRecorder.java: ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978438743 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadStatusRecorder.java: ## @@ -0,0 +1,186 @@ +/** + * Licensed to the Apache Software Foundat

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
J-HowHuang commented on code in PR #15175: URL: https://github.com/apache/pinot/pull/15175#discussion_r1978438023 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/RebalanceSummaryResult.java: ## @@ -86,12 +89,18 @@ public static class ServerSegm

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978434991 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,430 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978430512 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,423 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978434991 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,430 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
J-HowHuang commented on code in PR #15175: URL: https://github.com/apache/pinot/pull/15175#discussion_r1978432873 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -963,6 +974,15 @@ private Pair getInstancePartitionsF

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978431093 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadScheduler.java: ## @@ -0,0 +1,430 @@ +/** + * Licensed to the Apache Software Foundation (

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978429002 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadMetrics.java: ## @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Add predownload functionality to Pinot [pinot]

2025-03-03 Thread via GitHub
deemoliu commented on code in PR #14686: URL: https://github.com/apache/pinot/pull/14686#discussion_r1978426661 ## pinot-server/src/main/java/org/apache/pinot/server/predownload/PredownloadMetrics.java: ## @@ -0,0 +1,63 @@ +/** + * Licensed to the Apache Software Foundation (ASF

Re: [PR] Make ser/de part of the AggregationFunction [pinot]

2025-03-03 Thread via GitHub
xiangfu0 commented on code in PR #15158: URL: https://github.com/apache/pinot/pull/15158#discussion_r1978411130 ## pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java: ## @@ -84,15 +95,36 @@ public static RowDataBlock buildFromRows(List rows, D

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
somandal commented on code in PR #15175: URL: https://github.com/apache/pinot/pull/15175#discussion_r1978375341 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java: ## @@ -963,6 +974,15 @@ private Pair getInstancePartitionsFor

Re: [PR] Refactor murmur functions and support them in scalar functions for query [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #15160: URL: https://github.com/apache/pinot/pull/15160 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated: Refactor murmur functions to pinot-spi (#15160)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 74877be2aa Refactor murmur functions to pinot-sp

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
J-HowHuang commented on PR #15175: URL: https://github.com/apache/pinot/pull/15175#issuecomment-2695828038 > Add a pre-check item to check if disk utilization exceeds the safe threshold for each server Actually this doesn't make too much sense as pre-check doesn't have the knowledge

Re: [PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15175: URL: https://github.com/apache/pinot/pull/15175#issuecomment-2695799385 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15175?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add Disk Utilization Info into Rebalance API [pinot]

2025-03-03 Thread via GitHub
J-HowHuang opened a new pull request, #15175: URL: https://github.com/apache/pinot/pull/15175 ## Description Disk utilization check was added to controller's periodic task in https://github.com/apache/pinot/pull/15008. This change was to pause data ingestion automatically. Server

Re: [PR] Use v4 as the default raw index version [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15174: URL: https://github.com/apache/pinot/pull/15174#issuecomment-2695737570 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15174?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Minion tasks should not pick up problematic consuming segments [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15173: URL: https://github.com/apache/pinot/pull/15173#issuecomment-2695687656 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15173?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated (9b2bbe1e32 -> 04d21816bf)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 9b2bbe1e32 Bump com.fasterxml.jackson:jackson-bom from 2.18.2 to 2.18.3 (#15169) add 04d21816bf fix(ui): query s

[PR] Minion tasks should not pick up problematic consuming segments [pinot]

2025-03-03 Thread via GitHub
sajjad-moradi opened a new pull request, #15173: URL: https://github.com/apache/pinot/pull/15173 In segment commit end, Controller updates ZK in multiple steps (it does not use ZK transaction). In one step, it updates segment ZK metadata of committing segments (set segment.status as DONE

[PR] Use v4 as the default raw index version [pinot]

2025-03-03 Thread via GitHub
Jackie-Jiang opened a new pull request, #15174: URL: https://github.com/apache/pinot/pull/15174 `v4` has been thoroughly tested and all bugs are fixed in `1.3.0`. Now it is safe to make it the default version for raw index. -- This is an automated message from the Apache Git Service. To r

Re: [PR] fix(ui): query settings are not passing correctly when running via cmd+enter [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #15161: URL: https://github.com/apache/pinot/pull/15161 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Logical poc [pinot]

2025-03-03 Thread via GitHub
Jackie-Jiang commented on code in PR #15151: URL: https://github.com/apache/pinot/pull/15151#discussion_r1978243693 ## pinot-common/src/main/java/org/apache/pinot/common/utils/LogicalTableUtils.java: ## @@ -0,0 +1,165 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

Re: [PR] Adding perf benchmark logic for GroupIdGenerator hash map [pinot]

2025-03-03 Thread via GitHub
ankitsultana merged PR #14992: URL: https://github.com/apache/pinot/pull/14992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (04d21816bf -> 31441164c7)

2025-03-03 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 04d21816bf fix(ui): query settings are not passing correctly when running via cmd+enter (#15161) add 314411

Re: [PR] Bump com.fasterxml.jackson:jackson-bom from 2.18.2 to 2.18.3 [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #15169: URL: https://github.com/apache/pinot/pull/15169 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] JsonIndex V3 [pinot]

2025-03-03 Thread via GitHub
xiangfu0 closed pull request #15159: JsonIndex V3 URL: https://github.com/apache/pinot/pull/15159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commit

(pinot) branch master updated (6227c8e3d0 -> 6da5c32b87)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6227c8e3d0 Bump org.mockito:mockito-core from 5.15.2 to 5.16.0 (#15167) add 6da5c32b87 Bump software.amazon.awssd

(pinot) branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.3 deleted (was 4e3de89257)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.3 in repository https://gitbox.apache.org/repos/asf/pinot.git was 4e3de89257 Bump com.fasterxml.jackson:jackson-bom from 2.18.2 to 2

(pinot) branch master updated (6da5c32b87 -> 9b2bbe1e32)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 6da5c32b87 Bump software.amazon.awssdk:bom from 2.30.30 to 2.30.31 (#15168) add 9b2bbe1e32 Bump com.fasterxml.ja

(pinot) branch dependabot/maven/org.mockito-mockito-core-5.16.0 deleted (was 99f48ec662)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/org.mockito-mockito-core-5.16.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was 99f48ec662 Bump org.mockito:mockito-core from 5.15.2 to 5.16.0 The revisio

Re: [PR] Bump software.amazon.awssdk:bom from 2.30.30 to 2.30.31 [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #15168: URL: https://github.com/apache/pinot/pull/15168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.30.31 deleted (was c5022a514b)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.30.31 in repository https://gitbox.apache.org/repos/asf/pinot.git was c5022a514b Bump software.amazon.awssdk:bom from 2.30.30 to 2.30.31 The

Re: [PR] Bump org.mockito:mockito-core from 5.15.2 to 5.16.0 [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #15167: URL: https://github.com/apache/pinot/pull/15167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (777cd64c19 -> 6227c8e3d0)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 777cd64c19 Bump org.webjars:swagger-ui from 5.18.3 to 5.20.0 (#15166) add 6227c8e3d0 Bump org.mockito:mockito-cor

(pinot) branch dependabot/maven/org.webjars-swagger-ui-5.20.0 deleted (was a016f42a9a)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.20.0 in repository https://gitbox.apache.org/repos/asf/pinot.git was a016f42a9a Bump org.webjars:swagger-ui from 5.18.3 to 5.20.0 The revisions th

(pinot) branch master updated: Bump org.webjars:swagger-ui from 5.18.3 to 5.20.0 (#15166)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 777cd64c19 Bump org.webjars:swagger-ui from 5.18

Re: [PR] Bump org.webjars:swagger-ui from 5.18.3 to 5.20.0 [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #15166: URL: https://github.com/apache/pinot/pull/15166 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Correct Empty Aggregation Function Response [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15172: URL: https://github.com/apache/pinot/pull/15172#issuecomment-2695476002 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15172?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fixing ordering issue in subquery for time column in GAPFILL based queries [pinot]

2025-03-03 Thread via GitHub
ankitsultana merged PR #15096: URL: https://github.com/apache/pinot/pull/15096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (0fc838fadb -> 25f08870a1)

2025-03-03 Thread ankitsultana
This is an automated email from the ASF dual-hosted git repository. ankitsultana pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0fc838fadb MSE throttling: Set a hard limit on number of MSE threads (#15143) add 25f08870a1 Fixing orderin

Re: [PR] Adding perf benchmark logic for GroupIdGenerator hash map [pinot]

2025-03-03 Thread via GitHub
shauryachats commented on code in PR #14992: URL: https://github.com/apache/pinot/pull/14992#discussion_r1978123127 ## pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkObjectOpenHashMap.java: ## @@ -0,0 +1,130 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Fixing ordering issue in subquery for time column in GAPFILL based queries [pinot]

2025-03-03 Thread via GitHub
shauryachats commented on code in PR #15096: URL: https://github.com/apache/pinot/pull/15096#discussion_r1978102581 ## pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java: ## @@ -270,7 +275,7 @@ private List aggregateGapfilledData(Object timeCol, L

Re: [PR] Correct Empty Aggregation Function Response [pinot]

2025-03-03 Thread via GitHub
ashishjayamohan commented on code in PR #15172: URL: https://github.com/apache/pinot/pull/15172#discussion_r1978103228 ## pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java: ## @@ -968,11 +969,37 @@ private BrokerResponseNa

[PR] Correct Empty Aggregation Function Response [pinot]

2025-03-03 Thread via GitHub
ashishjayamohan opened a new pull request, #15172: URL: https://github.com/apache/pinot/pull/15172 - **Closes**: https://github.com/apache/pinot/issues/14629 - **Addresses**: https://github.com/apache/pinot/issues/13057 - This PR corrects the return response for aggregation functions on

Re: [PR] Adding perf benchmark logic for GroupIdGenerator hash map [pinot]

2025-03-03 Thread via GitHub
ankitsultana commented on code in PR #14992: URL: https://github.com/apache/pinot/pull/14992#discussion_r1978093749 ## pinot-perf/src/main/java/org/apache/pinot/perf/BenchmarkObjectOpenHashMap.java: ## @@ -0,0 +1,130 @@ +/** + * Licensed to the Apache Software Foundation (ASF) u

Re: [PR] Fixing ordering issue in subquery for time column in GAPFILL based queries [pinot]

2025-03-03 Thread via GitHub
ankitsultana commented on code in PR #15096: URL: https://github.com/apache/pinot/pull/15096#discussion_r1978079961 ## pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java: ## @@ -270,7 +275,7 @@ private List aggregateGapfilledData(Object timeCol, L

Re: [I] Controller fails to startup if DataDir cannot be created [pinot]

2025-03-03 Thread via GitHub
rseetham commented on issue #15127: URL: https://github.com/apache/pinot/issues/15127#issuecomment-2695309495 We had a cluster running. Our data dir points to hadoop. There was an issue with the hadoop name node calls failed for 4-5 hours until the issue was fixed. In that time, servers cou

Re: [I] Inconsistent Deduplication Behavior Between v1.2.0 and v1.3.0 [pinot]

2025-03-03 Thread via GitHub
klsince commented on issue #15163: URL: https://github.com/apache/pinot/issues/15163#issuecomment-2695192041 The old version didn't have TTL mechanism, so those two were unrecognized configs. ``` "unrecognizedProperties": { "/dedupConfig/dedupTimeColumn": "insertion_time",

Re: [I] Consuming Segments going into BAD State after forceCommit when dedup is enabled since version 1.3.0 [pinot]

2025-03-03 Thread via GitHub
klsince commented on issue #15162: URL: https://github.com/apache/pinot/issues/15162#issuecomment-2695187541 Thanks for reporting this. Did you see any errors/exceptions in the Server logs, particularly related to segment loading? -- This is an automated message from the Apache Git Servic

[I] Sometimes Some OFFLINE Table Entries Do Not Appear When Querying the Hybrid Table [pinot]

2025-03-03 Thread via GitHub
jburgoos opened a new issue, #15171: URL: https://github.com/apache/pinot/issues/15171 **Description** We are experiencing an issue where queries on a hybrid table in Apache Pinot do not always return all the expected data from the OFFLINE segments. However, when querying the OFFLINE

Re: [PR] Cancel subqueries after reduction [pinot]

2025-03-03 Thread via GitHub
gortiz commented on PR #15146: URL: https://github.com/apache/pinot/pull/15146#issuecomment-2694627373 I've added some commits to only send the cancel request on early terminated queries. Still, I'm not sure if this needs to be merged. In the current termination mechanism, when the result i

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-03-03 Thread via GitHub
gortiz merged PR #15143: URL: https://github.com/apache/pinot/pull/15143 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

(pinot) branch master updated: MSE throttling: Set a hard limit on number of MSE threads (#15143)

2025-03-03 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0fc838fadb MSE throttling: Set a hard limit on nu

Re: [PR] Enable force overwrite for partial upserts [pinot]

2025-03-03 Thread via GitHub
himanish-star commented on code in PR #15107: URL: https://github.com/apache/pinot/pull/15107#discussion_r1977467180 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertColumnarMerger.java: ## @@ -74,7 +75,10 @@ public void merge(LazyRo

Re: [PR] Enable force overwrite for partial upserts [pinot]

2025-03-03 Thread via GitHub
himanish-star commented on code in PR #15107: URL: https://github.com/apache/pinot/pull/15107#discussion_r1977467721 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertColumnarMerger.java: ## @@ -74,7 +75,10 @@ public void merge(LazyRo

Re: [PR] Improve minion observer stats to capture more granular stages of minion task execution [pinot]

2025-03-03 Thread via GitHub
shounakmk219 commented on code in PR #15118: URL: https://github.com/apache/pinot/pull/15118#discussion_r1977448235 ## pinot-minion/src/main/java/org/apache/pinot/minion/event/MinionProgressObserver.java: ## @@ -62,14 +64,29 @@ public synchronized void notifyTaskStart(PinotTaskC

[PR] Changes to support parallel test runs [pinot]

2025-03-03 Thread via GitHub
krishan1390 opened a new pull request, #15170: URL: https://github.com/apache/pinot/pull/15170 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] Improve minion observer stats to capture more granular stages of minion task execution [pinot]

2025-03-03 Thread via GitHub
shounakmk219 commented on code in PR #15118: URL: https://github.com/apache/pinot/pull/15118#discussion_r1977438420 ## pinot-spi/src/main/java/org/apache/pinot/spi/tasks/MinionTaskBaseObserverStats.java: ## @@ -34,8 +38,11 @@ */ public class MinionTaskBaseObserverStats { p

Re: [PR] Upgrade pulsar to 3.3.5 [pinot]

2025-03-03 Thread via GitHub
codecov-commenter commented on PR #15156: URL: https://github.com/apache/pinot/pull/15156#issuecomment-2691496919 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/15156?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Enable force overwrite for partial upserts [pinot]

2025-03-03 Thread via GitHub
klsince commented on code in PR #15107: URL: https://github.com/apache/pinot/pull/15107#discussion_r1975904977 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/merger/PartialUpsertColumnarMerger.java: ## @@ -74,7 +75,10 @@ public void merge(LazyRow prev

Re: [PR] Improve minion observer stats to capture more granular stages of minion task execution [pinot]

2025-03-03 Thread via GitHub
swaminathanmanish commented on code in PR #15118: URL: https://github.com/apache/pinot/pull/15118#discussion_r1977412212 ## pinot-minion/src/main/java/org/apache/pinot/minion/event/MinionProgressObserver.java: ## @@ -62,14 +64,29 @@ public synchronized void notifyTaskStart(Pinot

(pinot) branch dependabot/maven/org.mockito-mockito-core-5.16.0 created (now 99f48ec662)

2025-03-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.mockito-mockito-core-5.16.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at 99f48ec662 Bump org.mockito:mockito-core from 5.15.2 to 5.16.0 No new r

(pinot) branch dependabot/maven/org.webjars-swagger-ui-5.20.0 created (now a016f42a9a)

2025-03-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.webjars-swagger-ui-5.20.0 in repository https://gitbox.apache.org/repos/asf/pinot.git at a016f42a9a Bump org.webjars:swagger-ui from 5.18.3 to 5.20.0 No new revis

[PR] Bump org.mockito:mockito-core from 5.15.2 to 5.16.0 [pinot]

2025-03-03 Thread via GitHub
dependabot[bot] opened a new pull request, #15167: URL: https://github.com/apache/pinot/pull/15167 Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from 5.15.2 to 5.16.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockit

(pinot) branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.3 created (now 4e3de89257)

2025-03-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/com.fasterxml.jackson-jackson-bom-2.18.3 in repository https://gitbox.apache.org/repos/asf/pinot.git at 4e3de89257 Bump com.fasterxml.jackson:jackson-bom from 2.18.2 t

[PR] Bump com.fasterxml.jackson:jackson-bom from 2.18.2 to 2.18.3 [pinot]

2025-03-03 Thread via GitHub
dependabot[bot] opened a new pull request, #15169: URL: https://github.com/apache/pinot/pull/15169 Bumps [com.fasterxml.jackson:jackson-bom](https://github.com/FasterXML/jackson-bom) from 2.18.2 to 2.18.3. Commits https://github.com/FasterXML/jackson-bom/commit/f459157186d3243

[PR] Bump software.amazon.awssdk:bom from 2.30.30 to 2.30.31 [pinot]

2025-03-03 Thread via GitHub
dependabot[bot] opened a new pull request, #15168: URL: https://github.com/apache/pinot/pull/15168 Bumps software.amazon.awssdk:bom from 2.30.30 to 2.30.31. Most Recent Ignore Conditions Applied to This Pull Request | Dependency Name | Ignore Conditions | | --- | --- |

(pinot) branch dependabot/maven/software.amazon.awssdk-bom-2.30.31 created (now c5022a514b)

2025-03-03 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/software.amazon.awssdk-bom-2.30.31 in repository https://gitbox.apache.org/repos/asf/pinot.git at c5022a514b Bump software.amazon.awssdk:bom from 2.30.30 to 2.30.31 N

[PR] Bump org.webjars:swagger-ui from 5.18.3 to 5.20.0 [pinot]

2025-03-03 Thread via GitHub
dependabot[bot] opened a new pull request, #15166: URL: https://github.com/apache/pinot/pull/15166 Bumps [org.webjars:swagger-ui](https://github.com/swagger-api/swagger-ui) from 5.18.3 to 5.20.0. Release notes Sourced from https://github.com/swagger-api/swagger-ui/releases";>org.we

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-03-03 Thread via GitHub
gortiz commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1977302043 ## pinot-spi/src/main/java/org/apache/pinot/spi/executor/HardLimitExecutor.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-03-03 Thread via GitHub
gortiz commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1977302043 ## pinot-spi/src/main/java/org/apache/pinot/spi/executor/HardLimitExecutor.java: ## @@ -0,0 +1,94 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-03-03 Thread via GitHub
vrajat commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1977272723 ## pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java: ## @@ -76,11 +76,12 @@ default void toOutputStream(OutputStream outputStream) /**

Re: [PR] Refactor query error handling to use QueryErrorCode and QueryErrorMessage for improved clarity and consistency [pinot]

2025-03-03 Thread via GitHub
vrajat commented on code in PR #15037: URL: https://github.com/apache/pinot/pull/15037#discussion_r1977272204 ## pinot-common/src/main/java/org/apache/pinot/common/response/BrokerResponse.java: ## @@ -76,11 +76,12 @@ default void toOutputStream(OutputStream outputStream) /**

Re: [I] Multi-stage: Perf issue when IN expression has a lot of entries [pinot]

2025-03-03 Thread via GitHub
gortiz commented on issue #13617: URL: https://github.com/apache/pinot/issues/13617#issuecomment-2693721308 This issue is fixed in Calcite 1.39, which is going to be released soon. We decided to wait for that release instead of trying to create partial solutions in Pinot code. -- This is

Re: [PR] FIX: Modifying the helm chart used for Pinot Quickstart [pinot]

2025-03-03 Thread via GitHub
subhashini-26 commented on PR #14952: URL: https://github.com/apache/pinot/pull/14952#issuecomment-2693663393 > I think is likely to be an old feature, suggest to add to the readme how to configure a new namespace. @xiangfu0 Thanks for the review. The [quickstart documentation](http

Re: [PR] FIX: Modifying the helm chart used for Pinot Quickstart [pinot]

2025-03-03 Thread via GitHub
xiangfu0 merged PR #14952: URL: https://github.com/apache/pinot/pull/14952 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch master updated (3d6ca3fabc -> d818e33b3a)

2025-03-03 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 3d6ca3fabc Re-order Aggregation Optimizations (#15138) add d818e33b3a FIX: Modifying the helm chart used for Pino

Re: [PR] MSE throttling: Set a hard limit on number of MSE threads [pinot]

2025-03-03 Thread via GitHub
albertobastos commented on code in PR #15143: URL: https://github.com/apache/pinot/pull/15143#discussion_r1977026454 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -125,8 +125,8 @@ public synchronized void init(PinotConfigu

  1   2   >