krishan1390 commented on code in PR #15170:
URL: https://github.com/apache/pinot/pull/15170#discussion_r1978622237
##########
pinot-core/src/main/java/org/apache/pinot/core/util/ListenerConfigUtil.java:
##########
@@ -141,7 +142,7 @@ public static List<ListenerConfig>
buildServerAdminConfigs(PinotConfiguration se
String adminApiPortString =
serverConf.getProperty(CommonConstants.Server.CONFIG_OF_ADMIN_API_PORT);
if (adminApiPortString != null) {
listeners.add(
- new ListenerConfig(CommonConstants.HTTP_PROTOCOL, DEFAULT_HOST,
Integer.parseInt(adminApiPortString),
+ new ListenerConfig(CommonConstants.HTTP_PROTOCOL, DEFAULT_HOST,
NetUtils.findOpenPort(Integer.parseInt(adminApiPortString)),
Review Comment:
this isn't meant for production because we should stick to configured port
(for non test flow) rather than determine an available port. so will refactor
this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
