shauryachats commented on code in PR #15096:
URL: https://github.com/apache/pinot/pull/15096#discussion_r1978102581
##########
pinot-core/src/main/java/org/apache/pinot/core/query/reduce/GapfillProcessor.java:
##########
@@ -270,7 +275,7 @@ private List<Object[]> aggregateGapfilledData(Object
timeCol, List<Object[]> buc
}
Map<ExpressionContext, BlockValSet> blockValSetMap = new HashMap<>();
- for (int i = 1; i < dataSchema.getColumnNames().length; i++) {
+ for (int i = 0; i < dataSchema.getColumnNames().length; i++) {
Review Comment:
We skipped index 0 because we assumed the timeBucketColumn would be present
there, but with this change, it can now be present in any index.
It does not lead to any behavior change because the `blockValSetMap`
provides the `BlockValSet` which provides the list of values for the given
aggregation function, and even if the timeBucketColumn is present inside the
map, there is not going to be any retrieval for its `BlockValSet` in the
downstream functions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
