J-HowHuang commented on PR #15175: URL: https://github.com/apache/pinot/pull/15175#issuecomment-2695828038
> Add a pre-check item to check if disk utilization exceeds the safe threshold for each server Actually this doesn't make too much sense as pre-check doesn't have the knowledge of the instance assignment after the rebalance -- for rebalance with `reassignInstances=true`, there's no obvious way for pre-checker to check the disk utilization of the added instances because it has no idea who they are going to be. Better solution will be showing it in summary, or refactor the pre-checker so that it receives previous and new assignments (similar to `org.apache.pinot.controller.helix.core.rebalance.TableRebalancer#calculateDryRunSummary`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
