J-HowHuang commented on code in PR #15175:
URL: https://github.com/apache/pinot/pull/15175#discussion_r1978432873
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/rebalance/TableRebalancer.java:
##########
@@ -963,6 +974,15 @@ private Pair<InstancePartitions, Boolean>
getInstancePartitionsForTier(TableConf
}
}
+ private DiskUsageInfo getDiskUsageInfoOfInstance(String instanceId) {
+ return ResourceUtilizationInfo.getDiskUsageInfo(instanceId);
Review Comment:
This default to be 5 min. Configurable using controller config
`controller.resource.utilization.checker.frequency`.
These are the options I could think of:
1. solely depends on `controller.resource.utilization.checker.frequency`,
make it shorter if needed
2. update the disk utilization record (the same one
`org.apache.pinot.controller.validation.DiskUtilizationChecker` updates) of the
participating server instances every time rebalance is done (we can update with
the estimated value to avoid additional api calls). This involves adding
additional methods to the class
`org.apache.pinot.controller.validation.ResourceUtilizationInfo`.
3. Make API request to the server instance independently. This incurs more
api requests to the server and the impact on performance is unknown yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
