lnbest0707-uber commented on code in PR #13790:
URL: https://github.com/apache/pinot/pull/13790#discussion_r1804158972
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/TableConfigUtils.java:
##
@@ -173,15 +173,18 @@ public static void validate(TableConfi
lnbest0707-uber commented on code in PR #13790:
URL: https://github.com/apache/pinot/pull/13790#discussion_r1804155028
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##
@@ -774,15 +778,32 @@ Set getPartition
lnbest0707-uber commented on code in PR #13790:
URL: https://github.com/apache/pinot/pull/13790#discussion_r1804153036
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/utils/TableConfigUtilsTest.java:
##
@@ -686,9 +686,8 @@ public void ingestionStreamConfigsTe
suddendust commented on PR #14155:
URL: https://github.com/apache/pinot/pull/14155#issuecomment-2418564473
@Jackie-Jiang We're looping through all the enums now, so this should catch
any newly added metrics.
--
This is an automated message from the Apache Git Service.
To respond to the me
suddendust commented on PR #14155:
URL: https://github.com/apache/pinot/pull/14155#issuecomment-2418563852
@gortiz Explained in the PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
suddendust commented on code in PR #14155:
URL: https://github.com/apache/pinot/pull/14155#discussion_r1804151498
##
pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotJMXToPromMetricsTest.java:
##
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundatio
suddendust commented on code in PR #14155:
URL: https://github.com/apache/pinot/pull/14155#discussion_r1804151319
##
pinot-common/src/test/java/org/apache/pinot/common/metrics/PinotJMXToPromMetricsTest.java:
##
@@ -0,0 +1,266 @@
+/**
+ * Licensed to the Apache Software Foundatio
ankitsultana closed issue #14231: [flaky test] CLP Message Decoder
URL: https://github.com/apache/pinot/issues/14231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
yashmayya commented on code in PR #14233:
URL: https://github.com/apache/pinot/pull/14233#discussion_r1804044667
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -209,23 +244,37 @@ private void validateWindows(
deemoliu commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803909404
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompressio
jackluo923 commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803906656
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompress
jackluo923 commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803906656
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompress
deemoliu commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803900524
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompressio
deemoliu commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803900524
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompressio
deemoliu commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803900524
##
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompressio
lnbest0707-uber commented on code in PR #14229:
URL: https://github.com/apache/pinot/pull/14229#discussion_r1803884819
##
pinot-spi/src/test/java/org/apache/pinot/spi/utils/JsonUtilsTest.java:
##
@@ -641,4 +641,71 @@ public void testEmptyString()
List> flattenedRecords = Js
Jackie-Jiang commented on code in PR #14105:
URL: https://github.com/apache/pinot/pull/14105#discussion_r1803846655
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java:
##
@@ -76,11 +76,13 @@
public class VarB
Jackie-Jiang commented on code in PR #14105:
URL: https://github.com/apache/pinot/pull/14105#discussion_r1803816308
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java:
##
@@ -81,6 +80,12 @@ publ
Jackie-Jiang commented on code in PR #14235:
URL: https://github.com/apache/pinot/pull/14235#discussion_r1803811345
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##
@@ -170,8 +174,15 @@ public static List
applyDynamicEnvConfig(List conf
Map
chrajeshbabu commented on PR #14015:
URL: https://github.com/apache/pinot/pull/14015#issuecomment-2417717961
Rebased to latest code @Jackie-Jiang.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
Jackie-Jiang commented on code in PR #14233:
URL: https://github.com/apache/pinot/pull/14233#discussion_r1803610953
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -209,23 +244,37 @@ private void validateWindo
jackluo923 commented on code in PR #14105:
URL: https://github.com/apache/pinot/pull/14105#discussion_r1803587500
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV5.java:
##
@@ -0,0 +1,76 @@
+/**
+ * Licensed to th
chrajeshbabu commented on issue #14216:
URL: https://github.com/apache/pinot/issues/14216#issuecomment-2417535301
@jayeshchoudhary sorry it was with release 1.2.0. I am setting up Pinot
along with existing Kerberos based Hadoop cluster. Will share a video mostly by
tomorrow.
--
This is
deepthi912 commented on code in PR #14235:
URL: https://github.com/apache/pinot/pull/14235#discussion_r1803563957
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##
@@ -170,8 +173,15 @@ public static List
applyDynamicEnvConfig(List conf
Map e
raghavyadav01 commented on PR #14245:
URL: https://github.com/apache/pinot/pull/14245#issuecomment-2417486056
What is the current behavior for JSON column types? We should keep the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
Jackie-Jiang commented on code in PR #13943:
URL: https://github.com/apache/pinot/pull/13943#discussion_r1803542898
##
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##
@@ -100,26 +111,64 @@ public class QueryEnvironment {
private final Framew
raghavyadav01 commented on code in PR #14245:
URL: https://github.com/apache/pinot/pull/14245#discussion_r1803538115
##
pinot-controller/src/main/resources/app/components/Table.tsx:
##
@@ -462,8 +471,17 @@ export default function CustomizedTables({
{styleCell(cell
Jackie-Jiang merged PR #14248:
URL: https://github.com/apache/pinot/pull/14248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/com.google.cloud-libraries-bom-26.49.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 6e7480f62c Bump com.google.cloud:libraries-bom from 26.47.0 to 26.49.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 57e01eb0b7 Bump org.mockito:mockito-core from 5.14.1 to 5.14.2 (#14246)
add 9fdc2fec68 Bump com.google.cloud:libra
Jackie-Jiang merged PR #14247:
URL: https://github.com/apache/pinot/pull/14247
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/org.jline-jline-3.27.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
was c4cf47811a Bump org.jline:jline from 3.27.0 to 3.27.1
The revisions that were on this
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 9fdc2fec68 Bump com.google.cloud:libraries-bom from 26.47.0 to 26.49.0
(#14247)
add b556b375c7 Bump org.jline:jli
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/org.mockito-mockito-core-5.14.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
was cf8f083a4c Bump org.mockito:mockito-core from 5.14.1 to 5.14.2
The revision
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 57e01eb0b7 Bump org.mockito:mockito-core from 5.1
Jackie-Jiang merged PR #14246:
URL: https://github.com/apache/pinot/pull/14246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1803496921
##
pinot-controller/src/main/resources/package.json:
##
@@ -57,7 +57,8 @@
"url-loader": "4.1.1",
"webpack": "4.29.6",
"webpack-cli": "3.3.0",
-"w
bziobrowski commented on code in PR #14210:
URL: https://github.com/apache/pinot/pull/14210#discussion_r1803496298
##
pinot-controller/pom.xml:
##
@@ -121,13 +122,13 @@
-npm ci
+npm ci
Review Comment:
I reverted t
chenboat commented on code in PR #14229:
URL: https://github.com/apache/pinot/pull/14229#discussion_r1803475323
##
pinot-spi/src/test/java/org/apache/pinot/spi/utils/JsonUtilsTest.java:
##
@@ -641,4 +641,71 @@ public void testEmptyString()
List> flattenedRecords = JsonUtils
chenboat commented on code in PR #14229:
URL: https://github.com/apache/pinot/pull/14229#discussion_r1803476287
##
pinot-spi/src/test/java/org/apache/pinot/spi/utils/JsonUtilsTest.java:
##
@@ -641,4 +641,71 @@ public void testEmptyString()
List> flattenedRecords = JsonUtils
esakkiraj commented on code in PR #14245:
URL: https://github.com/apache/pinot/pull/14245#discussion_r1803165741
##
pinot-controller/src/main/resources/app/components/Table.tsx:
##
@@ -462,8 +471,17 @@ export default function CustomizedTables({
{styleCell(cellData
esakkiraj commented on PR #14245:
URL: https://github.com/apache/pinot/pull/14245#issuecomment-2416918444
> what will happen if the data is overflowing the cell? https://private-user-images.githubusercontent.com/41536903/377068103-aafcf12c-19dc-431f-91b2-328e8251c04f.png?jwt=eyJhbGciOiJIUzI1N
esakkiraj commented on PR #14245:
URL: https://github.com/apache/pinot/pull/14245#issuecomment-2416915102
> @esakkiraj what about other places where we show schema details like table
details page. are we using the same component to render schema table?
>
> https://private-user-images.
esakkiraj commented on code in PR #14245:
URL: https://github.com/apache/pinot/pull/14245#discussion_r1803146436
##
pinot-controller/src/main/resources/app/interfaces/types.d.ts:
##
@@ -28,8 +28,10 @@ declare module 'Models' {
customRenderer: JSX.Element
}
+ export ty
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 77627ba1fe colocated-without-hints (#13943)
add 7e84239568 Multi stage explain imprv (#14212)
No new revisions we
gortiz merged PR #14212:
URL: https://github.com/apache/pinot/pull/14212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 6061b8926a Fix race condition in IdealStateGroupCommit (#14237)
add 77627ba1fe colocated-without-hints (#13943)
N
gortiz merged PR #13943:
URL: https://github.com/apache/pinot/pull/13943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
jayeshchoudhary commented on issue #14216:
URL: https://github.com/apache/pinot/issues/14216#issuecomment-2416830670
@chrajeshbabu can you attach a video?
also which version are you using?
This might be related to new complex field we added ?
Ui fix - https://github.com/apache/pi
jayeshchoudhary commented on code in PR #14245:
URL: https://github.com/apache/pinot/pull/14245#discussion_r1803092474
##
pinot-controller/src/main/resources/app/components/Table.tsx:
##
@@ -462,8 +471,17 @@ export default function CustomizedTables({
{styleCell(ce
jayeshchoudhary commented on code in PR #14245:
URL: https://github.com/apache/pinot/pull/14245#discussion_r1803090548
##
pinot-controller/src/main/resources/app/interfaces/types.d.ts:
##
@@ -28,8 +28,10 @@ declare module 'Models' {
customRenderer: JSX.Element
}
+ exp
jayeshchoudhary commented on PR #14245:
URL: https://github.com/apache/pinot/pull/14245#issuecomment-2416814896
what will happen if the data is overflowing the cell?
https://github.com/user-attachments/assets/aafcf12c-19dc-431f-91b2-328e8251c04f";>
--
This is an automated message fr
jayeshchoudhary commented on PR #14245:
URL: https://github.com/apache/pinot/pull/14245#issuecomment-2416812646
@esakkiraj what about other places where we show schema details
like table details page. are we using the same component to render schema
table?
https://github.com/user-
t0mpere commented on code in PR #14235:
URL: https://github.com/apache/pinot/pull/14235#discussion_r1803035221
##
pinot-spi/src/main/java/org/apache/pinot/spi/env/PinotConfiguration.java:
##
@@ -170,8 +173,15 @@ public static List
applyDynamicEnvConfig(List conf
Map envi
xiangfu0 merged PR #14237:
URL: https://github.com/apache/pinot/pull/14237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6061b8926a Fix race condition in IdealStateGroup
gortiz commented on code in PR #13943:
URL: https://github.com/apache/pinot/pull/13943#discussion_r1802916505
##
pinot-query-planner/src/main/java/org/apache/pinot/query/QueryEnvironment.java:
##
@@ -100,26 +111,64 @@ public class QueryEnvironment {
private final FrameworkCon
gortiz commented on code in PR #13943:
URL: https://github.com/apache/pinot/pull/13943#discussion_r1802902579
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/hint/PinotHintStrategyTable.java:
##
@@ -108,4 +110,25 @@ public static String getHintOption(List hintL
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 4220d09e11 Upgraded clp-ffi.version from 0.4.5 to 0.4.7 (#14242)
add bb51514c25 Disable shading when pinot-fastdev
gortiz merged PR #13956:
URL: https://github.com/apache/pinot/pull/13956
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
dependabot[bot] opened a new pull request, #14248:
URL: https://github.com/apache/pinot/pull/14248
Bumps [org.jline:jline](https://github.com/jline/jline3) from 3.27.0 to
3.27.1.
Release notes
Sourced from https://github.com/jline/jline3/releases";>org.jline:jline's
releases.
dependabot[bot] opened a new pull request, #14247:
URL: https://github.com/apache/pinot/pull/14247
Bumps
[com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom)
from 26.47.0 to 26.49.0.
Release notes
Sourced from https://github.com/googleapis/java-cloud-bom/
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch dependabot/maven/org.jline-jline-3.27.1
in repository https://gitbox.apache.org/repos/asf/pinot.git
at c4cf47811a Bump org.jline:jline from 3.27.0 to 3.27.1
No new revisions were added
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/com.google.cloud-libraries-bom-26.49.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 6e7480f62c Bump com.google.cloud:libraries-bom from 26.47.0 to 26
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.mockito-mockito-core-5.14.2
in repository https://gitbox.apache.org/repos/asf/pinot.git
at cf8f083a4c Bump org.mockito:mockito-core from 5.14.1 to 5.14.2
No new r
dependabot[bot] opened a new pull request, #14246:
URL: https://github.com/apache/pinot/pull/14246
Bumps [org.mockito:mockito-core](https://github.com/mockito/mockito) from
5.14.1 to 5.14.2.
Release notes
Sourced from https://github.com/mockito/mockito/releases";>org.mockito:mockit
yashmayya commented on code in PR #14233:
URL: https://github.com/apache/pinot/pull/14233#discussion_r1802890826
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -209,23 +244,37 @@ private void validateWindows(
gortiz commented on code in PR #13943:
URL: https://github.com/apache/pinot/pull/13943#discussion_r180240
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -343,7 +343,9 @@ public static class Broker {
public static final String CONFIG_
bziobrowski commented on PR #14238:
URL: https://github.com/apache/pinot/pull/14238#issuecomment-2416406811
I don't think this problem can be addressed with better documentation
because errors returned by parsers have:
A. wrong position
B. point to wrong token
C. suggest empty list
esakkiraj commented on code in PR #14245:
URL: https://github.com/apache/pinot/pull/14245#discussion_r1802781385
##
pinot-controller/src/main/resources/app/components/Table.tsx:
##
@@ -462,8 +471,17 @@ export default function CustomizedTables({
{styleCell(cellData
esakkiraj opened a new pull request, #14245:
URL: https://github.com/apache/pinot/pull/14245
Support for Map data types in UI
Screenshots:
https://github.com/user-attachments/assets/236e3b5e-5d44-46e8-a98b-650ce34d63b9";>
https://github.com/user-attachments/assets
davecromberge commented on PR #14167:
URL: https://github.com/apache/pinot/pull/14167#issuecomment-2416295593
> @davecromberge Thanks for the contribution! Can you help also update the
pinot documentation about this new argument?
Yes @Jackie-Jiang will be happy to get this done.
--
rajat-sr1704 commented on issue #13780:
URL: https://github.com/apache/pinot/issues/13780#issuecomment-2415915552
> A few years ago, I had a working POC for multi-topic consumption. I also
wrote a design doc for it, but we ended up not using it in linkedin, so I did
not publish it. The idea
Jackie-Jiang commented on code in PR #14233:
URL: https://github.com/apache/pinot/pull/14233#discussion_r1802473173
##
pinot-query-planner/src/main/java/org/apache/pinot/calcite/rel/rules/PinotWindowExchangeNodeInsertRule.java:
##
@@ -234,8 +283,13 @@ private void validateWindow
74 matches
Mail list logo
