bziobrowski commented on PR #14238: URL: https://github.com/apache/pinot/pull/14238#issuecomment-2416406811
I don't think this problem can be addressed with better documentation because errors returned by parsers have: A. wrong position B. point to wrong token C. suggest empty list of tokens or wrong tokens That means user can't look at the error position and guess that it's caused by use of reserved keyword (see example in issue description). Switching to lookahead=1 reveals a number of keyword duplicates in config.fmpp and default_config.fmpp (as compilation errors in parser) and a number of clashes, mostly between productions and nonReservedKeywords. Quick test shows that we could minimize the number of added lookaheads by reducing the number of non-reserved or reserved keywords (the list is definitely too big) . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
