jackluo923 commented on code in PR #14008:
URL: https://github.com/apache/pinot/pull/14008#discussion_r1803906656
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/TarCompressionUtils.java:
##########
@@ -69,6 +69,12 @@ public class TarCompressionUtils {
private TarCompressionUtils() {
}
+ /**
+ * This generic compressed tar file extension does not bind to a particular
compressor. Decompression determines the
+ * appropriate compressor at run-time based on the file's magic number
irrespective of the file extension.
+ * Compression uses the default compressor automatically if this generic
extension is used.
+ */
+ public static final String TAR_COMPRESSED_FILE_EXTENSION = ".tar.compressed";
Review Comment:
The unit tests should be inside Apache commons library. You can name the
file extension to whatever you want, such as `.tar.deemoliu` and you'd still be
able to decompress the segment. Decompression does not rely on the file
extension to figure out the compressor to use for decompression.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
