lnbest0707-uber commented on code in PR #13790:
URL: https://github.com/apache/pinot/pull/13790#discussion_r1804155028
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/realtime/PinotLLCRealtimeSegmentManager.java:
##########
@@ -774,15 +778,32 @@ Set<Integer> getPartitionIds(StreamConfig streamConfig)
}
}
+ @VisibleForTesting
+ Set<Integer> getPartitionIds(List<StreamConfig> streamConfigs)
+ throws Exception {
+ Set<Integer> partitionIds = new HashSet<>();
+ for (int i = 0; i < streamConfigs.size(); i++) {
+ final int index = i;
+ try {
+
partitionIds.addAll(getPartitionIds(streamConfigs.get(index)).stream().map(
Review Comment:
This function is overloading an existing same name function. The other one
is also returning a Set<>. Usage of the output is only checking if partitionId
exists instead of checking its order.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
