Jackie-Jiang commented on code in PR #14105:
URL: https://github.com/apache/pinot/pull/14105#discussion_r1803816308


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java:
##########
@@ -81,6 +80,12 @@ public VarByteChunkForwardIndexReaderV4(PinotDataBuffer 
dataBuffer, FieldSpec.Da
     _isSingleValue = isSingleValue;
   }
 
+  public void validateIndexVersion(PinotDataBuffer dataBuffer) {

Review Comment:
   I meant we can add a `getVersion()` method into this class, and override it 
in v5 reader



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to