Jackie-Jiang commented on PR #13805:
URL: https://github.com/apache/pinot/pull/13805#issuecomment-2292931701
Thanks for the contribution! Can you help update pinot doc about this new
feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please lo
Jackie-Jiang commented on PR #13771:
URL: https://github.com/apache/pinot/pull/13771#issuecomment-2292930061
Any progress on this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
Jackie-Jiang commented on code in PR #12537:
URL: https://github.com/apache/pinot/pull/12537#discussion_r1719414769
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##
@@ -269,10 +271,22 @@ private String getQueryResponse(Strin
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 05068c5ef1 add assertions for AllocationFailureCo
Jackie-Jiang merged PR #13698:
URL: https://github.com/apache/pinot/pull/13698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1719325390
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/comparison/PolymorphicComparisonScalarFunction.java:
##
@@ -0,0 +1,75 @@
+/**
+ * Licensed to
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1719322780
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentMapPartitionDedupMetadataManager.java:
##
@@ -19,106 +19,124 @@
package org.apac
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1719320358
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/BasePartitionDedupMetadataManager.java:
##
@@ -0,0 +1,241 @@
+/**
+ * Licensed to the Apach
Jackie-Jiang commented on PR #13695:
URL: https://github.com/apache/pinot/pull/13695#issuecomment-2292817880
To ensure the ingestion order, we might be able to use a producer-consumer
pattern, where consumer thread creates `MessageBatch`s and put them into a
queue; another ingestion thread
Jackie-Jiang commented on PR #13823:
URL: https://github.com/apache/pinot/pull/13823#issuecomment-2292813500
Thanks for digging into the problem and finding the root cause!
I think `PrimitiveArrays` are introduced to reduce memory usage, so I'd
prefer keeping that and handle the new types
Jackie-Jiang commented on code in PR #13581:
URL: https://github.com/apache/pinot/pull/13581#discussion_r1719300091
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/MapFunctions.java:
##
@@ -0,0 +1,67 @@
+package org.apache.pinot.common.function.scalar;
+
+i
Jackie-Jiang commented on code in PR #13818:
URL: https://github.com/apache/pinot/pull/13818#discussion_r1719295854
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/BaseSingleTreeBuilder.java:
##
@@ -520,11 +520,22 @@ private void createFor
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1719266464
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##
@@ -554,7 +564,12 @@ private void buildDedupMeta(ImmutableS
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1719265711
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##
@@ -554,7 +564,12 @@ private void buildDedupMeta(ImmutableS
shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719260699
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTab
shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719256953
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTab
mcvsubbu commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719252764
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTableRe
mcvsubbu commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719252474
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTableRe
shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719249651
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##
@@ -103,12 +104,14 @@ public class PinotRealtimeTab
mcvsubbu commented on PR #13695:
URL: https://github.com/apache/pinot/pull/13695#issuecomment-2292663114
Is is useful to create a sub-class of RealtimeSegmentDataManager that
consumes asynchronously?
--
This is an automated message from the Apache Git Service.
To respond to the message, p
mcvsubbu commented on PR #13695:
URL: https://github.com/apache/pinot/pull/13695#issuecomment-2292661446
cc: @sajjad-moradi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719245526
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PauseStatus.java:
##
@@ -22,20 +22,27 @@
import com.fasterxml.jackson.annotation.JsonI
codecov-commenter commented on PR #13581:
URL: https://github.com/apache/pinot/pull/13581#issuecomment-2292556101
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13581?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
Jackie-Jiang commented on code in PR #13695:
URL: https://github.com/apache/pinot/pull/13695#discussion_r1719178241
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeSegmentDataManager.java:
##
@@ -679,6 +699,249 @@ private boolean processStreamEven
Jackie-Jiang commented on PR #13686:
URL: https://github.com/apache/pinot/pull/13686#issuecomment-2292540252
Can you help update Pinot doc about this new config
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL a
Jackie-Jiang commented on code in PR #13572:
URL: https://github.com/apache/pinot/pull/13572#discussion_r1719167693
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractorConfig.java:
##
@@ -27,17 +27,27 @@
Jackie-Jiang commented on code in PR #13581:
URL: https://github.com/apache/pinot/pull/13581#discussion_r1719161492
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/MapFunctions.java:
##
@@ -0,0 +1,213 @@
+/**
+ * Licensed to the Apache Software Foundation (
Jackie-Jiang commented on code in PR #13789:
URL: https://github.com/apache/pinot/pull/13789#discussion_r1719157723
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##
@@ -1013,6 +1013,22 @@ public boolean tryLoadExistingSegment(SegmentZK
Jackie-Jiang commented on PR #13347:
URL: https://github.com/apache/pinot/pull/13347#issuecomment-2292491838
Good job! Can you also help update the pinot doc to reflect this new feature?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
e-loftis opened a new pull request, #128:
URL: https://github.com/apache/pinot-site/pull/128
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
e-loftis closed pull request #127: adding new blog post for AWSxPinot
URL: https://github.com/apache/pinot-site/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
e-loftis opened a new pull request, #127:
URL: https://github.com/apache/pinot-site/pull/127
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-
ankitsultana merged PR #13347:
URL: https://github.com/apache/pinot/pull/13347
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new bd32dc9a64 Ensure upsert deletion consisten
klsince commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1719008024
##
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java:
##
@@ -554,7 +564,12 @@ private void buildDedupMeta(ImmutableSegm
Jackie-Jiang commented on PR #13721:
URL: https://github.com/apache/pinot/pull/13721#issuecomment-2292243173
Thanks for the contribution! Can you please also update the Pinot doc about
how to use this feature?
--
This is an automated message from the Apache Git Service.
To respond to the
Jackie-Jiang commented on code in PR #13816:
URL: https://github.com/apache/pinot/pull/13816#discussion_r1718984039
##
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java:
##
@@ -45,11 +45,11 @@ public class DynamicBrokerSelector impl
jasperjiaguo closed issue #12166: Query latency impact from linux disk read
ahead option
URL: https://github.com/apache/pinot/issues/12166
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
This is an automated email from the ASF dual-hosted git repository.
jiaguo pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new d1827c5a17 Support madvise for MmapMemory (#13721
jasperjiaguo merged PR #13721:
URL: https://github.com/apache/pinot/pull/13721
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on code in PR #13822:
URL: https://github.com/apache/pinot/pull/13822#discussion_r1718973225
##
pom.xml:
##
@@ -213,6 +213,7 @@
4.0.1
1.3.5
1.3.2
+1.0.0
Review Comment:
Is this a Java EE libarary? If not, let's keep it separately for
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/npm_and_yarn/pinot-controller/src/main/resources/elliptic-6.5.7
in repository https://gitbox.apache.org/repos/asf/pinot.git
at d8be4bf5bb Bump elliptic in /pinot-controller/
dependabot[bot] opened a new pull request, #13826:
URL: https://github.com/apache/pinot/pull/13826
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.4 to 6.5.7.
Commits
https://github.com/indutny/elliptic/commit/3e46a48fdd2ef2f89593e5e058d85530578c9761";>3e46a48
6.
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch dependabot/maven/commons-cli-commons-cli-1.9.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 48616b34f5 Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
The revisions that
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from df366cc1cc [Feature] Add the ability to compress and decompress tar
archive file with ZStandard and LZ4 compressors (#
Jackie-Jiang merged PR #13824:
URL: https://github.com/apache/pinot/pull/13824
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.27.5
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 147b07f354 Bump software.amazon.awssdk:bom from 2.27.3 to 2.27.5
The revi
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 2de771ab1a Bump software.amazon.awssdk:bom from 2.27.3 to 2.27.5
(#13824)
add 475aa3c043 Bump commons-cli:commons
Jackie-Jiang merged PR #13825:
URL: https://github.com/apache/pinot/pull/13825
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
deepthi912 commented on code in PR #13296:
URL: https://github.com/apache/pinot/pull/13296#discussion_r1718932021
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/TableViews.java:
##
@@ -110,6 +115,75 @@ public TableView getExternalView(
return ge
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1718826384
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentMapPartitionDedupMetadataManager.java:
##
@@ -19,106 +19,99 @@
package org.apach
zhtaoxiang commented on code in PR #13636:
URL: https://github.com/apache/pinot/pull/13636#discussion_r1718826384
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/dedup/ConcurrentMapPartitionDedupMetadataManager.java:
##
@@ -19,106 +19,99 @@
package org.apach
mcvsubbu commented on PR #13637:
URL: https://github.com/apache/pinot/pull/13637#issuecomment-2291766003
Can you please give me until EOD tomorrow to review this? thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/commons-cli-commons-cli-1.9.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at 48616b34f5 Bump commons-cli:commons-cli from 1.8.0 to 1.9.0
No new revisi
dependabot[bot] opened a new pull request, #13825:
URL: https://github.com/apache/pinot/pull/13825
Bumps commons-cli:commons-cli from 1.8.0 to 1.9.0.
[