Jackie-Jiang commented on code in PR #13581:
URL: https://github.com/apache/pinot/pull/13581#discussion_r1719300091


##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/MapFunctions.java:
##########
@@ -0,0 +1,67 @@
+package org.apache.pinot.common.function.scalar;
+
+import com.fasterxml.jackson.core.type.TypeReference;
+import com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.pinot.spi.annotations.ScalarFunction;
+
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Map;
+
+public class MapFunctions {
+    private MapFunctions() {
+    }
+
+    /**
+     * Internal Helper Function to convert Json String Values to Java Maps
+     * @param jsonString
+     * @return converted Java Map from JSON String
+     */
+    public static Map stringToMap(String jsonString) {

Review Comment:
   Any specific reason why you need a `LinkedHashMap`?
   `JsonUtils.stringToObject()` can be used in order to deserialize to a custom 
object



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to