Jackie-Jiang commented on code in PR #13822:
URL: https://github.com/apache/pinot/pull/13822#discussion_r1718973225
##########
pom.xml:
##########
@@ -213,6 +213,7 @@
<javax.servlet-api.version>4.0.1</javax.servlet-api.version>
<jakarta.annotation-api.version>1.3.5</jakarta.annotation-api.version>
<javax.annotation-api.version>1.3.2</javax.annotation-api.version>
+ <jspecify.version>1.0.0</jspecify.version>
Review Comment:
Is this a Java EE libarary? If not, let's keep it separately for easier
management
##########
pinot-common/pom.xml:
##########
@@ -275,6 +275,10 @@
<groupId>com.jayway.jsonpath</groupId>
<artifactId>json-path</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.jspecify</groupId>
+ <artifactId>jspecify</artifactId>
+ </dependency>
Review Comment:
(minor) We shouldn't need it as it is already included in `pinot-spi`
##########
pinot-common/src/main/java/org/apache/pinot/common/data/Segment.java:
##########
@@ -18,14 +18,14 @@
*/
package org.apache.pinot.common.data;
-import javax.annotation.Nonnull;
+import org.jspecify.annotations.NonNull;
Review Comment:
We are trying to follow the convention of only annotating the `nullable`
fields, and treat the fields not annotated as non-null. Since you are fixing
all annotations, let's remove the `Nonnull` ones.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
