shounakmk219 commented on code in PR #13803:
URL: https://github.com/apache/pinot/pull/13803#discussion_r1719249651
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotRealtimeTableResource.java:
##########
@@ -103,12 +104,14 @@ public class PinotRealtimeTableResource {
@ApiOperation(value = "Pause consumption of a realtime table", notes =
"Pause the consumption of a realtime table")
public Response pauseConsumption(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
+ @ApiParam(value = "Comment on pausing the consumption")
@QueryParam("comment") String comment,
Review Comment:
Yes its optional. I don’t think we need to make it mandatory in future.
> Also, how about we introduce default comment string in this class, and
pass that down?
Yes that's a good point. I am thinking of assigning the default value at the
caller code so that right default context is set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
