Jackie-Jiang commented on code in PR #13816:
URL: https://github.com/apache/pinot/pull/13816#discussion_r1718984039
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java:
##########
@@ -45,11 +45,11 @@ public class DynamicBrokerSelector implements
BrokerSelector, IZkDataListener {
private static final Logger LOGGER =
LoggerFactory.getLogger(DynamicBrokerSelector.class);
private static final Random RANDOM = new Random();
- private final AtomicReference<Map<String, List<String>>>
_tableToBrokerListMapRef = new AtomicReference<>();
- private final AtomicReference<List<String>> _allBrokerListRef = new
AtomicReference<>();
- private final ZkClient _zkClient;
- private final ExternalViewReader _evReader;
- private final List<String> _brokerList;
+ protected final AtomicReference<Map<String, List<String>>>
_tableToBrokerListMapRef = new AtomicReference<>();
+ protected final AtomicReference<List<String>> _allBrokerListRef = new
AtomicReference<>();
+ protected final ZkClient _zkClient;
+ protected final ExternalViewReader _evReader;
+ protected final List<String> _brokerList;
Review Comment:
Do we need to keep this list? This is very confusing as it contains the ZK
servers
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/DynamicBrokerSelector.java:
##########
@@ -45,11 +45,11 @@ public class DynamicBrokerSelector implements
BrokerSelector, IZkDataListener {
private static final Logger LOGGER =
LoggerFactory.getLogger(DynamicBrokerSelector.class);
private static final Random RANDOM = new Random();
- private final AtomicReference<Map<String, List<String>>>
_tableToBrokerListMapRef = new AtomicReference<>();
- private final AtomicReference<List<String>> _allBrokerListRef = new
AtomicReference<>();
- private final ZkClient _zkClient;
- private final ExternalViewReader _evReader;
- private final List<String> _brokerList;
+ protected final AtomicReference<Map<String, List<String>>>
_tableToBrokerListMapRef = new AtomicReference<>();
Review Comment:
Any specific reason you want to make them `protected`? Are you going to
extend this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
