jackluo923 commented on code in PR #13003:
URL: https://github.com/apache/pinot/pull/13003#discussion_r1697971089
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/invertedindex/RealtimeLuceneTextIndex.java:
##
@@ -181,6 +194,27 @@ private Mutable
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697953415
##
pinot-common/src/main/java/org/apache/pinot/common/metadata/ZKMetadataProvider.java:
##
@@ -73,6 +79,87 @@ public static void
setUserConfig(ZkHelixPropertyStor
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697949697
##
pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseSingleStageBrokerRequestHandler.java:
##
@@ -458,6 +458,14 @@ protected BrokerResponse han
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697946503
##
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##
@@ -353,6 +461,11 @@ public int getRateLimiterMap
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697944673
##
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##
@@ -279,6 +376,17 @@ private void
addQueryQuotaC
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697936829
##
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##
@@ -230,6 +251,82 @@ private void createOrUpdateR
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697935845
##
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##
@@ -46,21 +55,31 @@
import org.slf4j.Logger;
im
codecov-commenter commented on PR #13723:
URL: https://github.com/apache/pinot/pull/13723#issuecomment-2259723352
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13723?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697929757
##
pinot-common/src/main/java/org/apache/pinot/common/utils/DatabaseUtils.java:
##
@@ -155,4 +157,18 @@ public static String extractDatabaseFromQueryRequest(
shounakmk219 commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697927101
##
pinot-broker/src/main/java/org/apache/pinot/broker/broker/helix/BrokerResourceOnlineOfflineStateModelFactory.java:
##
@@ -81,6 +82,8 @@ public void onBecomeOnli
sullis opened a new pull request, #13723:
URL: https://github.com/apache/pinot/pull/13723
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
anandkrshaw opened a new issue, #13722:
URL: https://github.com/apache/pinot/issues/13722
When I check the server logs this is the only error I see - I assume there
should be an handling for malformed messages.
And pinot server should move ahead and not stop the consumption at all.
This is an automated email from the ASF dual-hosted git repository.
tingchen pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new f6da79924c Use ByteString.EMPTY to Prevent Prot
chenboat merged PR #13720:
URL: https://github.com/apache/pinot/pull/13720
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
abhioncbr commented on PR #13671:
URL: https://github.com/apache/pinot/pull/13671#issuecomment-2259454330
@jasperjiaguo, can you please review one more time? Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
klsince commented on code in PR #13544:
URL: https://github.com/apache/pinot/pull/13544#discussion_r1697688129
##
pinot-broker/src/main/java/org/apache/pinot/broker/queryquota/HelixExternalViewBasedQueryQuotaManager.java:
##
@@ -230,6 +251,82 @@ private void createOrUpdateRateLi
codecov-commenter commented on PR #13721:
URL: https://github.com/apache/pinot/pull/13721#issuecomment-2259363160
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13721?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.2.0-rc by this push:
new 30c15985bd [maven-relea
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.2.0-rc by this push:
new 41d89a1b10 [maven-relea
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to annotated tag release-1.2.0-rc0
in repository https://gitbox.apache.org/repos/asf/pinot.git
*** WARNING: tag release-1.2.0-rc0 was modified! ***
from 30c15985bd (commit)
to 4868d701cb (
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard c0c98cd94e [maven-release-plugin] prepare release release-1.2.0-rc0
This update removed existing revis
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.2.0-rc by this push:
new c0c98cd94e [maven-relea
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard 29a9c4bea5 [maven-release-plugin] prepare release release-1.2.0-rc0
This update removed existing revis
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to annotated tag release-1.2.0-rc0
in repository https://gitbox.apache.org/repos/asf/pinot.git
*** WARNING: tag release-1.2.0-rc0 was deleted! ***
tag was c12f9b66e7
This change permanently dis
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/release-1.2.0-rc by this push:
new 29a9c4bea5 [maven-relea
codecov-commenter commented on PR #13720:
URL: https://github.com/apache/pinot/pull/13720#issuecomment-2259287500
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13720?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a change to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
discard cc01b50f4c [maven-release-plugin] prepare for next development
iteration
omit 8068ac2b92 [maven-re
This is an automated email from the ASF dual-hosted git repository.
ankitsultana pushed a commit to branch release-1.2.0-rc
in repository https://gitbox.apache.org/repos/asf/pinot.git
commit 5b9a40f01532a3cf9b11a5fed07aaf74f5df77a7
Author: Ankit Sultana
AuthorDate: Tue Jul 30 15:31:51 2024 -0500
ankitsultana opened a new pull request, #13720:
URL: https://github.com/apache/pinot/pull/13720
`ByteString.empty()` was added in `3.20.0`. `ByteString.EMPTY` should be
equivalent and will allow lower protobuf versions to be used.
--
This is an automated message from the Apache Git Servic
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 95a526e29c Fixing requestId generator bug in Pin
xiangfu0 merged PR #13716:
URL: https://github.com/apache/pinot/pull/13716
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new ef769c09d3 Fix mvn javadoc:javadoc goal for Pino
xiangfu0 merged PR #13719:
URL: https://github.com/apache/pinot/pull/13719
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
codecov-commenter commented on PR #13719:
URL: https://github.com/apache/pinot/pull/13719#issuecomment-2259093791
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13719?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ankitsultana opened a new pull request, #13719:
URL: https://github.com/apache/pinot/pull/13719
Context in #13718.
Tested by running `mvn javadoc:javadoc -pl pinot-common`.
I am also running `mvn javadoc:javadoc` across the entire project to check
if there are any other issues.
ankitsultana opened a new issue, #13718:
URL: https://github.com/apache/pinot/issues/13718
While doing the Pinot 1.2 Release, the `mvn javadoc:javadoc` goal is failing
with the following error:
```
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-javadoc-plugin:3.2.0:
codecov-commenter commented on PR #13716:
URL: https://github.com/apache/pinot/pull/13716#issuecomment-2258981456
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13716?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
codecov-commenter commented on PR #13717:
URL: https://github.com/apache/pinot/pull/13717#issuecomment-2258970563
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13717?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
ankitsultana commented on issue #13707:
URL: https://github.com/apache/pinot/issues/13707#issuecomment-2258945863
This was fixed by the linked PR. #13708
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
ankitsultana closed issue #13707: Error in Pinot Release: "duplicate artifacts
attached"
URL: https://github.com/apache/pinot/issues/13707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
ege-st commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697385000
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##
@@ -272,6 +272,9 @@ public String getServerRoutingStats() {
}
priva
xiangfu0 commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697370356
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##
@@ -272,7 +272,10 @@ public String getServerRoutingStats() {
}
pr
ankitsultana commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697363434
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##
@@ -272,7 +272,10 @@ public String getServerRoutingStats() {
}
sajjad-moradi opened a new pull request, #13717:
URL: https://github.com/apache/pinot/pull/13717
Memory allocation for FixedByteSVMutableForwardIndex with large segment size
throws the following exception because of int overflow:
```
Caused by: java.lang.IllegalArgumentException: Illeg
xiangfu0 commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697355873
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##
@@ -272,6 +272,9 @@ public String getServerRoutingStats() {
}
pri
ege-st commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697348981
##
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##
@@ -272,6 +272,9 @@ public String getServerRoutingStats() {
}
priva
xiangfu0 opened a new pull request, #13716:
URL: https://github.com/apache/pinot/pull/13716
The issue here is that `_requestIdGenerator` is local to the HttpResource
and will be created for every http request, so the requestId is always 0.
--
This is an automated message from the Apac
sullis commented on PR #13709:
URL: https://github.com/apache/pinot/pull/13709#issuecomment-2258821665
CI build is passing 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
codecov-commenter commented on PR #13715:
URL: https://github.com/apache/pinot/pull/13715#issuecomment-2258469804
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13715?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
yashmayya commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696997758
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/comparison/PolymorphicComparisonScalarFunction.java:
##
@@ -0,0 +1,75 @@
+/**
+ * Licensed to th
yashmayya commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696983002
##
pinot-core/src/main/java/org/apache/pinot/core/query/postaggregation/PostAggregationFunction.java:
##
@@ -38,20 +37,20 @@ public class PostAggregationFunction {
yashmayya opened a new pull request, #13715:
URL: https://github.com/apache/pinot/pull/13715
- The `LiteralValueExtractor` is currently hardcoded to only handle string
literals and all call sites convert literals to strings before creating a
`LiteralValueExtractor`.
- This causes issues
yashmayya commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696969801
##
pinot-core/src/main/java/org/apache/pinot/core/query/postaggregation/PostAggregationFunction.java:
##
@@ -38,20 +37,20 @@ public class PostAggregationFunction {
gortiz commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696959578
##
pinot-core/src/main/java/org/apache/pinot/core/query/postaggregation/PostAggregationFunction.java:
##
@@ -38,20 +37,20 @@ public class PostAggregationFunction {
gortiz commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696958932
##
pinot-core/src/main/java/org/apache/pinot/core/query/postaggregation/PostAggregationFunction.java:
##
@@ -38,20 +37,20 @@ public class PostAggregationFunction {
gortiz commented on code in PR #13711:
URL: https://github.com/apache/pinot/pull/13711#discussion_r1696957306
##
pinot-core/src/main/java/org/apache/pinot/core/query/postaggregation/PostAggregationFunction.java:
##
@@ -38,20 +37,20 @@ public class PostAggregationFunction {
yashmayya commented on PR #13711:
URL: https://github.com/apache/pinot/pull/13711#issuecomment-2258300426
> Since this is a v1 engine entity, I've updated it to go back to argument
count based function lookup for now, until the literal handling is updated
either in https://github.com/apache
yashmayya commented on PR #13711:
URL: https://github.com/apache/pinot/pull/13711#issuecomment-2258219043
There's a bug in `PostAggregationHandler` that is causing the query `SELECT
AirlineID, CASE WHEN Sum(ArrDelay) < 0 THEN 0 WHEN SUM(ArrDelay) > 0 THEN
SUM(ArrDelay) END AS SumArrDelay FR
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/org.asynchttpclient-async-http-client-3.0.0
in repository https://gitbox.apache.org/repos/asf/pinot.git
at da4a3475e6 Bump org.asynchttpclient:async-http-client from 2
dependabot[bot] opened a new pull request, #13714:
URL: https://github.com/apache/pinot/pull/13714
Bumps
[org.asynchttpclient:async-http-client](https://github.com/AsyncHttpClient/async-http-client)
from 2.12.3 to 3.0.0.
Release notes
Sourced from https://github.com/AsyncHttpClien
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.26.25
in repository https://gitbox.apache.org/repos/asf/pinot.git
was 02939d35de Bump software.amazon.awssdk:bom from 2.26.21 to 2.26.25
T
This is an automated email from the ASF dual-hosted git repository.
github-bot pushed a change to branch
dependabot/maven/software.amazon.awssdk-bom-2.26.26
in repository https://gitbox.apache.org/repos/asf/pinot.git
at b7742c3d7f Bump software.amazon.awssdk:bom from 2.26.21 to 2.26.26
N
dependabot[bot] commented on PR #13692:
URL: https://github.com/apache/pinot/pull/13692#issuecomment-2258158605
Superseded by #13713.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
dependabot[bot] closed pull request #13692: Bump software.amazon.awssdk:bom
from 2.26.21 to 2.26.25
URL: https://github.com/apache/pinot/pull/13692
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to th
dependabot[bot] opened a new pull request, #13713:
URL: https://github.com/apache/pinot/pull/13713
Bumps software.amazon.awssdk:bom from 2.26.21 to 2.26.26.
[ which disabled the CLP tests. Once
we have the CLP binaries for aarch64 we can enable these tes
gortiz commented on PR #13711:
URL: https://github.com/apache/pinot/pull/13711#issuecomment-2258012177
> Note that the polymorphic scalar comparison functions only support
comparing two arguments of the same type. In case arguments of two different
types need to be compared, an explicit cas
vrajat opened a new pull request, #13712:
URL: https://github.com/apache/pinot/pull/13712
STREAM_DATA_LOSS was added to notify that there was a gap in a real time
stream. It is a boolean where 1 denotes that a gap and therefore a data loss
was detected. The only solution is recreate the rea
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 835949b645 Automatically detect whether a v1 quer
gortiz merged PR #13628:
URL: https://github.com/apache/pinot/pull/13628
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
codecov-commenter commented on PR #13711:
URL: https://github.com/apache/pinot/pull/13711#issuecomment-2257934060
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/13711?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u
gortiz commented on PR #13303:
URL: https://github.com/apache/pinot/pull/13303#issuecomment-2257911612
> Let's not rush through it.
But at the same time please try to prioritize the review of this PR. It has
been opened for a while and the performance (and stability!) gain is very
im
This is an automated email from the ASF dual-hosted git repository.
gortiz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 6ad08a7016 Fix colocated join when no mapping pro
gortiz merged PR #13666:
URL: https://github.com/apache/pinot/pull/13666
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apach
yashmayya opened a new pull request, #13711:
URL: https://github.com/apache/pinot/pull/13711
- Fixes https://github.com/apache/pinot/issues/13699
- The function registry was recently refactored in
https://github.com/apache/pinot/pull/13573/ which also added support for
polymorphic scalar
80 matches
Mail list logo
