ege-st commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697348981
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##########
@@ -272,6 +272,9 @@ public String getServerRoutingStats() {
}
private long getRequestId() {
+ if (_requestIdGenerator.get() == Long.MAX_VALUE) {
+ _requestIdGenerator.set(0);
+ }
Review Comment:
```suggestion
_requestIdGenerator.compareAndSet(Long.MAX_VALUE, 0);
```
Otherwise, it would be possible for multiple concurrent threads to run
through this set the value to `0` in such a way that they all wind up with a
request id of `0`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
