yashmayya commented on PR #13711: URL: https://github.com/apache/pinot/pull/13711#issuecomment-2258300426
> Since this is a v1 engine entity, I've updated it to go back to argument count based function lookup for now, until the literal handling is updated either in https://github.com/apache/pinot/pull/13673 (which adds polymorphic scalar function support to some other v1 engine entities and also has util methods to convert between the Thrift literals and the Pinot types appropriately) or in a separate followup PR. The alternative would be to fall back to the `double` based scalar comparison function in case of heterogeneous argument types in the polymorphic scalar comparison functions and rely on the [FunctionInvoker's type conversion](https://github.com/apache/pinot/blob/835949b64529b8e5c0bb49474cdec2e17c9050f7/pinot-common/src/main/java/org/apache/pinot/common/function/FunctionInvoker.java#L94). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
