ankitsultana commented on code in PR #13716:
URL: https://github.com/apache/pinot/pull/13716#discussion_r1697363434
##########
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java:
##########
@@ -272,7 +272,10 @@ public String getServerRoutingStats() {
}
private long getRequestId() {
- return _requestIdGenerator.getAndIncrement();
+ if (REQUEST_ID_GENERATOR.get() == Long.MAX_VALUE) {
Review Comment:
nit: Do we really need to handle this? Even at 1M QPS, it would take 10^18 /
10^6 = 10^12 seconds for a broker to hit this.
Also, technically there's a race condition here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
