yashmayya opened a new pull request, #13711: URL: https://github.com/apache/pinot/pull/13711
- Fixes https://github.com/apache/pinot/issues/13699 - The function registry was recently refactored in https://github.com/apache/pinot/pull/13573/ which also added support for polymorphic scalar functions. - This patch adds polymorphic scalar function implementations for `=` and `!=` which are probably the most useful ones. A follow-up patch will add support for the remaining scalar comparison functions. - Currently, the function registry's lookup by argument type is only used in the v2 engine although eventually all usages of the lookup by argument number will be moved to the lookup by argument type. When that's done, these polymorphic scalar functions will automatically be supported by the v1 engine as well. Until that's done though, these new polymorphic scalar functions will default to the `double` based scalar comparison functions when looking up by argument number for backward compatibility. - Note that the polymorphic scalar comparison functions only support comparing two arguments of the same type. In case arguments of two different types need to be compared, an explicit cast should be added by the user. This behavior is similar to Postgres. - All the scalar comparison functions are marked as null intolerant because they should return `null` if any argument is `null`. Again, this matches Postgres behavior. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
