(pinot) branch master updated: Do not hard code resource class in BaseClusterIntegrationTest (#13400)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new b15155460a Do not hard code resource class in Ba

Re: [PR] Misc fix/enhancement on integration tests [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang commented on code in PR #13400: URL: https://github.com/apache/pinot/pull/13400#discussion_r1640594399 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerStatelessTest.java: ## @@ -203,8 +203,10 @@ public void testPinotTa

Re: [PR] Misc fix/enhancement on integration tests [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang merged PR #13400: URL: https://github.com/apache/pinot/pull/13400 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Misc fix/enhancement on integration tests [pinot]

2024-06-14 Thread via GitHub
codecov-commenter commented on PR #13400: URL: https://github.com/apache/pinot/pull/13400#issuecomment-2169018893 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13400?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Misc fix/enhancement on integration tests [pinot]

2024-06-14 Thread via GitHub
klsince commented on code in PR #13400: URL: https://github.com/apache/pinot/pull/13400#discussion_r1640573760 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerStatelessTest.java: ## @@ -203,8 +203,10 @@ public void testPinotTaskMan

[PR] Do not hard code resource class in BaseClusterIntegrationTest [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang opened a new pull request, #13400: URL: https://github.com/apache/pinot/pull/13400 Makes it easier to be reused in other package -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Reset controller port when stopping the controller in ControllerTest [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang merged PR #13399: URL: https://github.com/apache/pinot/pull/13399 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Reset controller port when stopping the controller in ControllerTest (#13399)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0ff43b517f Reset controller port when stopping th

[PR] Reset controller port when stopping the controller in ControllerTest [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang opened a new pull request, #13399: URL: https://github.com/apache/pinot/pull/13399 Reset the controller port when stopping the controller so that it won't carry over the old value from the stopped controller -- This is an automated message from the Apache Git Service. To resp

(pinot) branch master updated (4a428ec3a9 -> 689115026f)

2024-06-14 Thread xbli
This is an automated email from the ASF dual-hosted git repository. xbli pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 4a428ec3a9 Avoid port conflict in integration tests (#13390) add 689115026f [partial-upsert] configure early release

Re: [PR] [partial-upsert] configure early release of _partitionGroupConsumerSemaphore in RealtimeSegmentDataManager [pinot]

2024-06-14 Thread via GitHub
klsince merged PR #13256: URL: https://github.com/apache/pinot/pull/13256 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] Avoid port conflict in integration tests [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang merged PR #13390: URL: https://github.com/apache/pinot/pull/13390 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (228fa75244 -> 4a428ec3a9)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 228fa75244 Bump net.openhft:chronicle-core from 2.25ea15 to 2.26ea1 (#13395) add 4a428ec3a9 Avoid port conflict i

(pinot) branch dependabot/maven/net.openhft-chronicle-core-2.26ea1 deleted (was 43b93b5bd1)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/net.openhft-chronicle-core-2.26ea1 in repository https://gitbox.apache.org/repos/asf/pinot.git was 43b93b5bd1 Bump net.openhft:chronicle-core from 2.25ea15 to 2.26ea1 The

(pinot) branch master updated (226e731bac -> 228fa75244)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 226e731bac Remove app-assembler from integration tests pom.xml (#13397) add 228fa75244 Bump net.openhft:chronicle-

Re: [PR] Bump net.openhft:chronicle-core from 2.25ea15 to 2.26ea1 [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang merged PR #13395: URL: https://github.com/apache/pinot/pull/13395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated (830388d123 -> 226e731bac)

2024-06-14 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 830388d123 track segments for snapshotting even if they lost all comparisons (#13388) add 226e731bac Remove app-

Re: [PR] Remove appassembler build plugin from integration-tests pom.xml [pinot]

2024-06-14 Thread via GitHub
xiangfu0 merged PR #13397: URL: https://github.com/apache/pinot/pull/13397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

Re: [PR] Move resolveComparisonTies from addOrReplaceSegment to base class [pinot]

2024-06-14 Thread via GitHub
klsince commented on code in PR #13396: URL: https://github.com/apache/pinot/pull/13396#discussion_r1640214899 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -558,9 +558,20 @@ public void addSegment(Immut

Re: [I] SIGSEGV on Realtime Servers [pinot]

2024-06-14 Thread via GitHub
sajjad-moradi commented on issue #13398: URL: https://github.com/apache/pinot/issues/13398#issuecomment-2168537846 CC: @Jackie-Jiang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[I] SIGSEGV on Realtime Servers [pinot]

2024-06-14 Thread via GitHub
sajjad-moradi opened a new issue, #13398: URL: https://github.com/apache/pinot/issues/13398 ## Summary There is a race condition happening when the following two threads want to build/download a segment. 1. consuming thread (in building the segment in RETAINING state) 2. helix thre

Re: [I] Null Pointer Exception in arrayagg function with empty column data [pinot]

2024-06-14 Thread via GitHub
xiangfu0 commented on issue #13343: URL: https://github.com/apache/pinot/issues/13343#issuecomment-2168534409 This is fixed, can you try to test on the latest master branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Remove appassembler build plugin from integration-tests pom.xml [pinot]

2024-06-14 Thread via GitHub
codecov-commenter commented on PR #13397: URL: https://github.com/apache/pinot/pull/13397#issuecomment-2168454185 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13397?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Remove appassembler build plugin from integration-tests pom.xml [pinot]

2024-06-14 Thread via GitHub
abhioncbr opened a new pull request, #13397: URL: https://github.com/apache/pinot/pull/13397 TODO -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: co

Re: [PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-14 Thread via GitHub
klsince merged PR #13388: URL: https://github.com/apache/pinot/pull/13388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

Re: [PR] track segments for snapshotting even if they lost all comparisons [pinot]

2024-06-14 Thread via GitHub
klsince commented on code in PR #13388: URL: https://github.com/apache/pinot/pull/13388#discussion_r1640058344 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -933,7 +943,6 @@ protected void doTakeSnapshot

Re: [PR] Move resolveComparisonTies from addOrReplaceSegment to base class [pinot]

2024-06-14 Thread via GitHub
codecov-commenter commented on PR #13396: URL: https://github.com/apache/pinot/pull/13396#issuecomment-2168091932 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13396?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Move resolveComparisonTies from addOrReplaceSegment to base class [pinot]

2024-06-14 Thread via GitHub
tibrewalpratik17 opened a new pull request, #13396: URL: https://github.com/apache/pinot/pull/13396 Moving `resolveComparisonTies` from `addOrReplaceSegment` to base class. There are 2 ways of doing this: - Always call `resolveComparisonTies` in base class before calling `addOrReplace

(pinot) branch dependabot/maven/net.openhft-chronicle-core-2.26ea1 created (now 43b93b5bd1)

2024-06-14 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/net.openhft-chronicle-core-2.26ea1 in repository https://gitbox.apache.org/repos/asf/pinot.git at 43b93b5bd1 Bump net.openhft:chronicle-core from 2.25ea15 to 2.26ea1

[PR] Bump net.openhft:chronicle-core from 2.25ea15 to 2.26ea1 [pinot]

2024-06-14 Thread via GitHub
dependabot[bot] opened a new pull request, #13395: URL: https://github.com/apache/pinot/pull/13395 Bumps [net.openhft:chronicle-core](https://github.com/OpenHFT/Chronicle-Core) from 2.25ea15 to 2.26ea1. Release notes Sourced from https://github.com/OpenHFT/Chronicle-Core/releases"

Re: [PR] New buffers [pinot]

2024-06-14 Thread via GitHub
gortiz commented on code in PR #13304: URL: https://github.com/apache/pinot/pull/13304#discussion_r1639622538 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/DataBuffer.java: ## @@ -0,0 +1,292 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] New buffers [pinot]

2024-06-14 Thread via GitHub
gortiz commented on code in PR #13304: URL: https://github.com/apache/pinot/pull/13304#discussion_r1639621657 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/CompoundDataBuffer.java: ## @@ -0,0 +1,665 @@ +/** + * Licensed to the Apache Software Foundation

Re: [PR] New buffers [pinot]

2024-06-14 Thread via GitHub
gortiz commented on code in PR #13304: URL: https://github.com/apache/pinot/pull/13304#discussion_r1639621917 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/DataBuffer.java: ## @@ -0,0 +1,292 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] New buffers [pinot]

2024-06-14 Thread via GitHub
gortiz commented on code in PR #13304: URL: https://github.com/apache/pinot/pull/13304#discussion_r1639621299 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/DataBufferPinotInputStream.java: ## @@ -0,0 +1,243 @@ +/** + * Licensed to the Apache Software Fou

Re: [PR] New buffers [pinot]

2024-06-14 Thread via GitHub
gortiz commented on code in PR #13304: URL: https://github.com/apache/pinot/pull/13304#discussion_r1639585173 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/memory/DataBuffer.java: ## @@ -0,0 +1,292 @@ +/** + * Licensed to the Apache Software Foundation (ASF) un

Re: [PR] Improve error message for max rows in join limit breach [pinot]

2024-06-14 Thread via GitHub
codecov-commenter commented on PR #13394: URL: https://github.com/apache/pinot/pull/13394#issuecomment-2167653182 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13394?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: Use a two server setup for multi-stage query engine backward compatibility regression test suite (#13371)

2024-06-14 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6245aa4f11 Use a two server setup for multi-stage

Re: [PR] Use a two server setup for multi-stage query engine backward compatibility regression test suite [pinot]

2024-06-14 Thread via GitHub
gortiz merged PR #13371: URL: https://github.com/apache/pinot/pull/13371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Add query quota limiter on database [pinot]

2024-06-14 Thread via GitHub
codecov-commenter commented on PR #13392: URL: https://github.com/apache/pinot/pull/13392#issuecomment-2167526389 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13392?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Impose storage quotas on realtime tables [pinot]

2024-06-14 Thread via GitHub
codecov-commenter commented on PR #13393: URL: https://github.com/apache/pinot/pull/13393#issuecomment-2167514459 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/13393?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

(pinot) branch master updated: add unit test for StringFunctions encodeUrl (#13391)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0a8efaa67d add unit test for StringFunctions enco

Re: [PR] add unit test for StringFunctions encodeUrl [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang merged PR #13391: URL: https://github.com/apache/pinot/pull/13391 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: Refactored compatibility-verifier module (#13359)

2024-06-14 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 0dd78f1392 Refactored compatibility-verifier modu

Re: [PR] Refactored compatibility-verifier module [pinot]

2024-06-14 Thread via GitHub
Jackie-Jiang merged PR #13359: URL: https://github.com/apache/pinot/pull/13359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] [partial-upsert] configure early release of _partitionGroupConsumerSemaphore in RealtimeSegmentDataManager [pinot]

2024-06-14 Thread via GitHub
tibrewalpratik17 commented on code in PR #13256: URL: https://github.com/apache/pinot/pull/13256#discussion_r1639419684 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java: ## @@ -61,6 +64,12 @@ public static TableUps

[PR] Impose storage quotas on realtime tables [pinot]

2024-06-14 Thread via GitHub
shounakmk219 opened a new pull request, #13393: URL: https://github.com/apache/pinot/pull/13393 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

[PR] Add query quota limiter on database [pinot]

2024-06-14 Thread via GitHub
shounakmk219 opened a new pull request, #13392: URL: https://github.com/apache/pinot/pull/13392 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [partial-upsert] configure early release of _partitionGroupConsumerSemaphore in RealtimeSegmentDataManager [pinot]

2024-06-14 Thread via GitHub
tibrewalpratik17 commented on code in PR #13256: URL: https://github.com/apache/pinot/pull/13256#discussion_r1639381537 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/TableUpsertMetadataManagerFactory.java: ## @@ -61,6 +64,12 @@ public static TableUps