klsince commented on code in PR #13388:
URL: https://github.com/apache/pinot/pull/13388#discussion_r1640058344
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -933,7 +943,6 @@ protected void doTakeSnapshot() {
continue;
}
immutableSegment.persistValidDocIdsSnapshot();
- _updatedSegmentsSinceLastSnapshot.remove(segment);
Review Comment:
Right, if it keeps erroring out and the set is not cleared, then many
segments would be taken snapshots repeatedly. I’d assume such error case would
be rare and if it happened things are not getting worse than before when all
segments were take snapshots all the time. I’ll probably skip this optimization
for now and revisit when we see need. But good point anyway.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
