klsince commented on code in PR #13400:
URL: https://github.com/apache/pinot/pull/13400#discussion_r1640573760


##########
pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManagerStatelessTest.java:
##########
@@ -203,8 +203,10 @@ public void testPinotTaskManagerSchedulerWithRestart()
         "JobGroupNames should have SegmentGenerationAndPushTask only");
     validateJob(MinionConstants.SegmentGenerationAndPushTask.TASK_TYPE, "0 
*/10 * ? * * *");
 
-    // Restart controller
+    // Restart controller. We need to set the port after stopping the 
controller because we are reusing the same config.
+    int controllerPort = _controllerPort;
     stopController();
+    _controllerPort = controllerPort;

Review Comment:
   If not set like here, will the port be assigned randomly? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to