tibrewalpratik17 opened a new pull request, #13396: URL: https://github.com/apache/pinot/pull/13396
Moving `resolveComparisonTies` from `addOrReplaceSegment` to base class. There are 2 ways of doing this: - Always call `resolveComparisonTies` in base class before calling `addOrReplaceSegment`. There are 3 instances of `addOrReplaceSegment` calls in base class. - Put `resolveComparisonTies` inside `addOrReplaceSegment` method in base class itself and change the abstract method name to `doAddOrReplaceSegment`. This is in parity with other methods we have in extended class - `doAddRecord`, `doRemoveExpiredPrimaryKeys`, `doUpdateRecord` where we prefix the abstract method by **`do`**. We are doing the latter here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
