klsince commented on code in PR #13396:
URL: https://github.com/apache/pinot/pull/13396#discussion_r1640214899
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -558,9 +558,20 @@ public void addSegment(ImmutableSegmentImpl segment,
@Nullable ThreadSafeMutable
addOrReplaceSegment(segment, validDocIds, queryableDocIds,
recordInfoIterator, null, null);
}
- protected abstract void addOrReplaceSegment(ImmutableSegmentImpl segment,
ThreadSafeMutableRoaringBitmap validDocIds,
+ private void addOrReplaceSegment(ImmutableSegmentImpl segment,
ThreadSafeMutableRoaringBitmap validDocIds,
Review Comment:
would suggest to keep this method signature, otherwise, lgtm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
