(pinot) annotated tag release-1.1.0-rc1 deleted (was 0c323caa05)

2024-03-22 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0-rc1 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0-rc1 was deleted! *** tag was 0c323caa05 The revisions that were on th

Re: [PR] Consistency in API response for live broker [pinot]

2024-03-22 Thread via GitHub
cypherean commented on code in PR #12201: URL: https://github.com/apache/pinot/pull/12201#discussion_r1536580339 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableInstances.java: ## @@ -170,9 +171,12 @@ public List getLiveBrokersForTable( @

(pinot) annotated tag release-1.1.0 updated (c2606742bb -> e3a6c25a18)

2024-03-22 Thread vvivekiyer
This is an automated email from the ASF dual-hosted git repository. vvivekiyer pushed a change to annotated tag release-1.1.0 in repository https://gitbox.apache.org/repos/asf/pinot.git *** WARNING: tag release-1.1.0 was modified! *** from c2606742bb (commit) to e3a6c25a18 (tag) tagg

Re: [PR] Replace the usage of commons-collections to commons-collections4 [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12711: URL: https://github.com/apache/pinot/pull/12711#issuecomment-2016319642 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12711?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [I] Issues with min/max over big_decimal field when using Multi-stage engine [pinot]

2024-03-22 Thread via GitHub
dorlevi commented on issue #12705: URL: https://github.com/apache/pinot/issues/12705#issuecomment-2016312707 The original query` select min(block_number) from org_2dYiMRMfas142XRKQ3bJIqmN3V6_erc20_balance_changes limit 10` works well on v1 for us; casting as double works, -- This

Re: [I] Issues with min/max over big_decimal field when using Multi-stage engine [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang commented on issue #12705: URL: https://github.com/apache/pinot/issues/12705#issuecomment-2016311372 Can you try `select min(cast(block_number as double)) from org_2dYiMRMfas142XRKQ3bJIqmN3V6_erc20_balance_changes limit 10` and see if it works? Even in `v1` this query won't be

[PR] upgrade maven-shade-plugin version to 3.5.2 [pinot]

2024-03-22 Thread via GitHub
xiangfu0 opened a new pull request, #12712: URL: https://github.com/apache/pinot/pull/12712 Upgrade maven-shade-plugin version from 3.2.x to 3.5.2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] Upgrade pulsar version to 2.11.4 [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang commented on code in PR #12708: URL: https://github.com/apache/pinot/pull/12708#discussion_r1536536072 ## pom.xml: ## @@ -217,6 +217,7 @@ 9.4.54.v20240208 9.37.3 1.77 +2.11.4 Review Comment: The dependency is not declared in the root pom thoug

[PR] Replace the usage of commons-collections to commons-collections4 [pinot]

2024-03-22 Thread via GitHub
xiangfu0 opened a new pull request, #12711: URL: https://github.com/apache/pinot/pull/12711 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6

Re: [I] Issues with min/max over big_decimal field when using Multi-stage engine [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang commented on issue #12705: URL: https://github.com/apache/pinot/issues/12705#issuecomment-2016255367 Could be related to #12670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] Bump io.airlift:aircompressor from 0.21 to 0.26 [pinot]

2024-03-22 Thread via GitHub
xiangfu0 merged PR #12620: URL: https://github.com/apache/pinot/pull/12620 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

(pinot) branch dependabot/maven/io.airlift-aircompressor-0.26 deleted (was 343451d556)

2024-03-22 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/io.airlift-aircompressor-0.26 in repository https://gitbox.apache.org/repos/asf/pinot.git was 343451d556 move airlift version definition to root pom The revisions that wer

(pinot) branch master updated: Bump io.airlift:aircompressor from 0.21 to 0.26 (#12620)

2024-03-22 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 17c0436672 Bump io.airlift:aircompressor from 0.

Re: [PR] Add support for phrase search with wildcard and prefix matching for Lucene indexed tables [pinot]

2024-03-22 Thread via GitHub
chenboat commented on code in PR #12680: URL: https://github.com/apache/pinot/pull/12680#discussion_r1536461667 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/utils/LuceneTextIndexUtils.java: ## @@ -0,0 +1,72 @@ +/** + * Licensed to the Apache Software Found

Re: [PR] Add some additional metrics for Minion tasks [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12710: URL: https://github.com/apache/pinot/pull/12710#issuecomment-2016217271 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12710?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Add some additional metrics for Minion tasks [pinot]

2024-03-22 Thread via GitHub
vvivekiyer opened a new pull request, #12710: URL: https://github.com/apache/pinot/pull/12710 PR adds some additional metrics for Minion tasks. Adds the following metrics: - SEGMENTS_DOWNLOADED - SEGMENTS_UPLOADED - SEGMENT_SIZE_DOWNLOADED - SEGMENT_SIZE_UPLOADED - RECO

(pinot) 01/01: Extract methods for Pinot table ideal state

2024-03-22 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a commit to branch full-auto-oss-abstraction in repository https://gitbox.apache.org/repos/asf/pinot.git commit f0e458d1baec2deb7084a2f37afcee3ee586ceac Author: jlli_LinkedIn AuthorDate: Fri Mar 22 16:00:43 2024 -070

(pinot) branch full-auto-oss-abstraction created (now f0e458d1ba)

2024-03-22 Thread jlli
This is an automated email from the ASF dual-hosted git repository. jlli pushed a change to branch full-auto-oss-abstraction in repository https://gitbox.apache.org/repos/asf/pinot.git at f0e458d1ba Extract methods for Pinot table ideal state This branch includes the following new commits

Re: [PR] refine when to registerSegment when to add/replaceSegment for upsert tables [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12709: URL: https://github.com/apache/pinot/pull/12709#issuecomment-2016043863 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12709?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Upgrade pulsar version to 2.11.4 [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12708: URL: https://github.com/apache/pinot/pull/12708#issuecomment-2016036361 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12708?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

svn commit: r68065 - /dev/pinot/apache-pinot-1.1.0-rc1/ /release/pinot/apache-pinot-1.1.0/

2024-03-22 Thread mcvsubbu
Author: mcvsubbu Date: Fri Mar 22 22:26:40 2024 New Revision: 68065 Log: Step 1 to finalize 1.1.0-rc1 Moving apache-pinot-1.1.0-rc1 from dev to release Added: release/pinot/apache-pinot-1.1.0/ - copied from r68064, dev/pinot/apache-pinot-1.1.0-rc1/ Removed: dev/pinot/apache-pinot

[PR] refine when to registerSegment when to add/replaceSegment for upsert tables [pinot]

2024-03-22 Thread via GitHub
klsince opened a new pull request, #12709: URL: https://github.com/apache/pinot/pull/12709 this PR refines when to registerSegment when to add/replaceSegment for upsert tables. Basically, when adding a new segment, we should register it before processing with partitionUpsertMetadataM

Re: [PR] add SegmentContext to collect validDocIds bitmaps for many segments together [pinot]

2024-03-22 Thread via GitHub
klsince commented on code in PR #12694: URL: https://github.com/apache/pinot/pull/12694#discussion_r1536258715 ## pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java: ## @@ -256,8 +257,9 @@ private InstanceResponseBlock executeInternal(S

Re: [PR] Upgrade guava version to 33.1.0-jre [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12707: URL: https://github.com/apache/pinot/pull/12707#issuecomment-2015982324 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12707?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] Upgrade pulsar version to 2.11.4 [pinot]

2024-03-22 Thread via GitHub
xiangfu0 opened a new pull request, #12708: URL: https://github.com/apache/pinot/pull/12708 Upgrade pulsar version to 2.11.4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

(pinot) branch dependabot/maven/io.airlift-aircompressor-0.26 updated (0f3d63bab8 -> 343451d556)

2024-03-22 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/io.airlift-aircompressor-0.26 in repository https://gitbox.apache.org/repos/asf/pinot.git discard 0f3d63bab8 move airlift version definition to root pom discard 3fc4f2dd09 Bum

(pinot) branch dependabot/maven/io.airlift-aircompressor-0.26 updated (3fc4f2dd09 -> 0f3d63bab8)

2024-03-22 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a change to branch dependabot/maven/io.airlift-aircompressor-0.26 in repository https://gitbox.apache.org/repos/asf/pinot.git from 3fc4f2dd09 Bump io.airlift:aircompressor from 0.21 to 0.26 add 0f3d63bab8

(pinot) branch master updated: Consolidate bouncycastle libraries (#12706)

2024-03-22 Thread xiangfu
This is an automated email from the ASF dual-hosted git repository. xiangfu pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 02fd51d8bb Consolidate bouncycastle libraries (#

Re: [PR] Consolidate bouncycastle libraries [pinot]

2024-03-22 Thread via GitHub
xiangfu0 merged PR #12706: URL: https://github.com/apache/pinot/pull/12706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apa

[PR] Upgrade guava version to 33.1.0-jre [pinot]

2024-03-22 Thread via GitHub
xiangfu0 opened a new pull request, #12707: URL: https://github.com/apache/pinot/pull/12707 Upgrade guava version to [33.1.0-jre](https://mvnrepository.com/artifact/com.google.guava/guava/33.1.0-jre) -- This is an automated message from the Apache Git Service. To respond to the message, p

Re: [PR] Consolidate bouncycastle libraries [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12706: URL: https://github.com/apache/pinot/pull/12706#issuecomment-2015909665 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12706?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] add SegmentContext to collect validDocIds bitmaps for many segments together [pinot]

2024-03-22 Thread via GitHub
tibrewalpratik17 commented on code in PR #12694: URL: https://github.com/apache/pinot/pull/12694#discussion_r1536170709 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapTableUpsertMetadataManager.java: ## @@ -55,6 +58,14 @@ public Map getPa

[PR] Consolidate bouncycastle libraries [pinot]

2024-03-22 Thread via GitHub
xiangfu0 opened a new pull request, #12706: URL: https://github.com/apache/pinot/pull/12706 Consolidate all bouncycastle libraries to version 1.77 for Kafka and Pulsar plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

(pinot) branch master updated: Upgrade all Apache commons dependencies (#12692)

2024-03-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 1b2c5898e5 Upgrade all Apache commons dependencie

Re: [PR] Upgrade all Apache commons dependencies [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang merged PR #12692: URL: https://github.com/apache/pinot/pull/12692 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Upgrade all Apache commons dependencies [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang commented on code in PR #12692: URL: https://github.com/apache/pinot/pull/12692#discussion_r1535929098 ## pom.xml: ## @@ -697,6 +662,85 @@ import + + +org.apache.commons +commons-lang3 +${commons-lang3.version}

Re: [PR] Upgrade all Apache commons dependencies [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang commented on code in PR #12692: URL: https://github.com/apache/pinot/pull/12692#discussion_r1535926425 ## pom.xml: ## @@ -426,38 +438,6 @@ - -commons-cli -commons-cli -1.6.0 - - -org.apa

Re: [PR] Bump org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.1 [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang closed pull request #12701: Bump org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.1 URL: https://github.com/apache/pinot/pull/12701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

(pinot) branch dependabot/maven/org.apache.spark-spark-sql_2.12-3.5.1 deleted (was b4e41a76e7)

2024-03-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.spark-spark-sql_2.12-3.5.1 in repository https://gitbox.apache.org/repos/asf/pinot.git was b4e41a76e7 Bump org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.

(pinot) branch master updated: Bump org.apache.maven.plugins:maven-jxr-plugin from 2.3 to 3.3.2 (#12700)

2024-03-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new d51ec09c94 Bump org.apache.maven.plugins:maven-jx

Re: [PR] Bump org.apache.maven.plugins:maven-jxr-plugin from 2.3 to 3.3.2 [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang merged PR #12700: URL: https://github.com/apache/pinot/pull/12700 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

Re: [PR] Bump org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.1 [pinot]

2024-03-22 Thread via GitHub
dependabot[bot] commented on PR #12701: URL: https://github.com/apache/pinot/pull/12701#issuecomment-2015527115 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.3.2 deleted (was d0cc9341c9)

2024-03-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.3.2 in repository https://gitbox.apache.org/repos/asf/pinot.git was d0cc9341c9 Bump org.apache.maven.plugins:maven-jxr-plugin fr

Re: [PR] bump netty to 4.1.108 [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang merged PR #12702: URL: https://github.com/apache/pinot/pull/12702 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot

(pinot) branch master updated: bump netty to 4.1.108 (#12702)

2024-03-22 Thread jackie
This is an automated email from the ASF dual-hosted git repository. jackie pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 3f15c1280c bump netty to 4.1.108 (#12702) 3f15c12

[I] Issues with min/max over big_decimal field when using Multi-stage engine [pinot]

2024-03-22 Thread via GitHub
dorlevi opened a new issue, #12705: URL: https://github.com/apache/pinot/issues/12705 A simple min/max over a big_decimal fails when using the multi-stage engine, **Query:** `select min(block_number) from org_2dYiMRMfas142XRKQ3bJIqmN3V6_erc20_balance_changes limit 10` **Erro

[PR] Multi stage stats [pinot]

2024-03-22 Thread via GitHub
gortiz opened a new pull request, #12704: URL: https://github.com/apache/pinot/pull/12704 At this moment this PR is a draft where I'm trying to modify the way stats are collected and encoded in multi-stage engine. The plan is to: 1. Use enums as stat keys 2. Collect stats per st

Re: [PR] bump netty to 4.1.108 [pinot]

2024-03-22 Thread via GitHub
sullis commented on PR #12702: URL: https://github.com/apache/pinot/pull/12702#issuecomment-2015402596 ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] bump netty to 4.1.108 [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12702: URL: https://github.com/apache/pinot/pull/12702#issuecomment-2015271682 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12702?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

[PR] bump netty to 4.1.108 [pinot]

2024-03-22 Thread via GitHub
sullis opened a new pull request, #12702: URL: https://github.com/apache/pinot/pull/12702 https://netty.io/news/2024/03/21/4-1-108-Final.html -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] Add base class for merging and accumulating custom objects [pinot]

2024-03-22 Thread via GitHub
davecromberge commented on PR #12685: URL: https://github.com/apache/pinot/pull/12685#issuecomment-2015130624 @Jackie-Jiang I will update the description with more details as to why this change is necessary for Datasketches. Concerning `backward-incompatibility` - I think it is probab

Re: [PR] Json extract index filter support [pinot]

2024-03-22 Thread via GitHub
saurabhd336 commented on PR #12683: URL: https://github.com/apache/pinot/pull/12683#issuecomment-2015073004 @Jackie-Jiang updated the PR to let `getMatchingFlattenedDocsMap` accept jsonPath string with $ itself (similar to `getMatchingFlattenedDocIds`) As for the nested exclusive pred

Re: [PR] Fix error message on database context mismatch in v1 query [pinot]

2024-03-22 Thread via GitHub
shounakmk219 commented on code in PR #12699: URL: https://github.com/apache/pinot/pull/12699#discussion_r1535522749 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -260,6 +260,8 @@ private String getQueryResponse(String

Re: [I] Proposal to Harmonize Pinot Dependency Management [pinot]

2024-03-22 Thread via GitHub
xiangfu0 commented on issue #12676: URL: https://github.com/apache/pinot/issues/12676#issuecomment-2015020523 Here is my +100 to this approach. Curious on the best practice for managing the plugins/connectors to handle multiple versions of same library, e.g. Spark2 and Spark3 support, et

(pinot) branch dependabot/maven/org.apache.spark-spark-sql_2.12-3.5.1 created (now b4e41a76e7)

2024-03-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.spark-spark-sql_2.12-3.5.1 in repository https://gitbox.apache.org/repos/asf/pinot.git at b4e41a76e7 Bump org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.

[PR] Bump org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.1 [pinot]

2024-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12701: URL: https://github.com/apache/pinot/pull/12701 Bumps org.apache.spark:spark-sql_2.12 from 2.4.8 to 3.5.1. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.a

(pinot) branch dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.3.2 created (now d0cc9341c9)

2024-03-22 Thread github-bot
This is an automated email from the ASF dual-hosted git repository. github-bot pushed a change to branch dependabot/maven/org.apache.maven.plugins-maven-jxr-plugin-3.3.2 in repository https://gitbox.apache.org/repos/asf/pinot.git at d0cc9341c9 Bump org.apache.maven.plugins:maven-jxr-plugi

[PR] Bump org.apache.maven.plugins:maven-jxr-plugin from 2.3 to 3.3.2 [pinot]

2024-03-22 Thread via GitHub
dependabot[bot] opened a new pull request, #12700: URL: https://github.com/apache/pinot/pull/12700 Bumps [org.apache.maven.plugins:maven-jxr-plugin](https://github.com/apache/maven-jxr) from 2.3 to 3.3.2. Release notes Sourced from https://github.com/apache/maven-jxr/releases";>or

Re: [PR] 12508: Feature add segment rows flush config [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12681: URL: https://github.com/apache/pinot/pull/12681#issuecomment-2014907773 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12681?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] 12508: Feature add segment rows flush config [pinot]

2024-03-22 Thread via GitHub
karthi07 commented on PR #12681: URL: https://github.com/apache/pinot/pull/12681#issuecomment-2014830665 @Jackie-Jiang Your suggestions were helpful, I updated the docs and renamed the FixedThreshold. let me know if the docs need additional changes. Should I merge #12684 into my bran

Re: [PR] Fix error message on database context mismatch in v1 query [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12699: URL: https://github.com/apache/pinot/pull/12699#issuecomment-2014817807 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12699?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Fix error message on database context mismatch in v1 query [pinot]

2024-03-22 Thread via GitHub
gortiz commented on code in PR #12699: URL: https://github.com/apache/pinot/pull/12699#discussion_r1535344777 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -260,6 +260,8 @@ private String getQueryResponse(String query,

Re: [PR] Fix error message on database context mismatch in v1 query [pinot]

2024-03-22 Thread via GitHub
gortiz commented on code in PR #12699: URL: https://github.com/apache/pinot/pull/12699#discussion_r1535344777 ## pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java: ## @@ -260,6 +260,8 @@ private String getQueryResponse(String query,

[PR] Fix error message on database context mismatch in v1 query [pinot]

2024-03-22 Thread via GitHub
shounakmk219 opened a new pull request, #12699: URL: https://github.com/apache/pinot/pull/12699 On conflicting database context in the v1 query request such as Header : `Database: db2` Query : `select * from db1.foo limit 10` right now the error message says ``` It seems that

Re: [I] Support for SHOW TABLES and DESCRIBE Commands [pinot]

2024-03-22 Thread via GitHub
aadilkhalifa commented on issue #9200: URL: https://github.com/apache/pinot/issues/9200#issuecomment-2014744065 @marregui Hi. I'm working on it here https://github.com/apache/pinot/pull/12537 -- This is an automated message from the Apache Git Service. To respond to the message, please lo

Re: [I] Support for SHOW TABLES and DESCRIBE Commands [pinot]

2024-03-22 Thread via GitHub
marregui commented on issue #9200: URL: https://github.com/apache/pinot/issues/9200#issuecomment-2014737584 hi!, I saw this tasty feature and I must have it. Could I please know the status?, if nobody is currently working on it due to too busy schedules, may I please take it? thank you --

Re: [PR] Add GZIP Compression Codec (#11434) [pinot]

2024-03-22 Thread via GitHub
marregui commented on PR #12668: URL: https://github.com/apache/pinot/pull/12668#issuecomment-2014724301 [benchmark_no_dict_string_compression.txt](https://github.com/apache/pinot/files/14720625/benchmark_no_dict_string_compression.txt) I finally managed to run the benchmark for strin

Re: [PR] Add GZIP Compression Codec (#11434) [pinot]

2024-03-22 Thread via GitHub
marregui commented on code in PR #12668: URL: https://github.com/apache/pinot/pull/12668#discussion_r1535312725 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/GZIPCompressor.java: ## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] Add GZIP Compression Codec (#11434) [pinot]

2024-03-22 Thread via GitHub
marregui commented on code in PR #12668: URL: https://github.com/apache/pinot/pull/12668#discussion_r1535312278 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/compression/GZIPCompressor.java: ## @@ -0,0 +1,62 @@ +/** + * Licensed to the Apache Software Fo

Re: [PR] Cleanup the consumer interfaces and legacy code [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12697: URL: https://github.com/apache/pinot/pull/12697#issuecomment-2014711364 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12697?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add minionInstanceTag config to minion-tasks for resource isolation [pinot]

2024-03-22 Thread via GitHub
tibrewalpratik17 commented on PR #12459: URL: https://github.com/apache/pinot/pull/12459#issuecomment-2014693940 > Thanks a lot @tibrewalpratik17 . Would you be able to create a github issue to track this effort? LGTM. Could you please create github issues to track the additional work?

Re: [PR] Add minionInstanceTag config to minion-tasks for resource isolation [pinot]

2024-03-22 Thread via GitHub
tibrewalpratik17 commented on code in PR #12459: URL: https://github.com/apache/pinot/pull/12459#discussion_r1535292589 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/generator/BaseTaskGenerator.java: ## @@ -120,4 +123,23 @@ public List generateT

[I] MinionTenant as a table config [pinot]

2024-03-22 Thread via GitHub
tibrewalpratik17 opened a new issue, #12698: URL: https://github.com/apache/pinot/issues/12698 Supersedes #11240 In order to achieve resource isolation for minion jobs. These are the work streams to track: - [ ] Acknowledging minionInstanceTag task config for scheduled j

[PR] Cleanup the consumer interfaces and legacy code [pinot]

2024-03-22 Thread via GitHub
Jackie-Jiang opened a new pull request, #12697: URL: https://github.com/apache/pinot/pull/12697 Deprecate: - `PartitionLevelConsumer`: Use `PartitionGroupConsumer` instead - In `MessageBatch`: - `getMessageAtIndex()`: Use `getStreamMessage()` instead - `getMessageBytesAtIndex(

(pinot) branch master updated (00fdc5f511 -> af0e5b82ba)

2024-03-22 Thread gortiz
This is an automated email from the ASF dual-hosted git repository. gortiz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 00fdc5f511 [multistage] support database/namespace in v2 (#12591) add af0e5b82ba Add a way to pass `database` con

Re: [PR] Add a way to pass `database` context as header from swagger UI [pinot]

2024-03-22 Thread via GitHub
gortiz merged PR #12695: URL: https://github.com/apache/pinot/pull/12695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apach

Re: [PR] Json extract index filter support [pinot]

2024-03-22 Thread via GitHub
saurabhd336 commented on code in PR #12683: URL: https://github.com/apache/pinot/pull/12683#discussion_r1535253891 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java: ## @@ -367,10 +379,18 @@ public void convertFlatte

Re: [I] [multistage]: Support different output formats(XML, JSON, DOT and TEXT) for explain physical plan [pinot]

2024-03-22 Thread via GitHub
gortiz commented on issue #11039: URL: https://github.com/apache/pinot/issues/11039#issuecomment-2014622111 I've created https://github.com/apache/pinot/issues/12696 to show the current explain state and to propose a new version where explain behaves in the same way in V1 and V2. I'm not pl

[I] Improve and unify explain plan [pinot]

2024-03-22 Thread via GitHub
gortiz opened a new issue, #12696: URL: https://github.com/apache/pinot/issues/12696 # Proposal: Multi Stage actual physical/implementation explain Apache Pinot has some particularities that make `explain` sentences a bit more complex than customers may be used to. First, Pinot is

Re: [I] [multistage]: Support different output formats(XML, JSON, DOT and TEXT) for explain physical plan [pinot]

2024-03-22 Thread via GitHub
gortiz commented on issue #11039: URL: https://github.com/apache/pinot/issues/11039#issuecomment-2014605480 I've created [this document](https://docs.google.com/document/d/14YD-Tbb2NxxMULwpFX4b6uC9YjhygPYgiHvI0jt0q0s/edit#heading=h.om79hm58o58) to try to summarize the current explain option

Re: [PR] Improved null check for varargs [pinot]

2024-03-22 Thread via GitHub
gortiz commented on code in PR #12673: URL: https://github.com/apache/pinot/pull/12673#discussion_r1535213030 ## pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java: ## @@ -190,7 +190,7 @@ protected void updateBrokerData() public String ge

Re: [PR] Upgrade all Apache commons dependencies [pinot]

2024-03-22 Thread via GitHub
gortiz commented on code in PR #12692: URL: https://github.com/apache/pinot/pull/12692#discussion_r1535204382 ## pom.xml: ## @@ -697,6 +662,85 @@ import + + +org.apache.commons +commons-lang3 +${commons-lang3.version} +

Re: [PR] Upgrade all Apache commons dependencies [pinot]

2024-03-22 Thread via GitHub
gortiz commented on code in PR #12692: URL: https://github.com/apache/pinot/pull/12692#discussion_r1535201984 ## pom.xml: ## @@ -426,38 +438,6 @@ - -commons-cli -commons-cli -1.6.0 - - -org.apache.co

Re: [PR] Add a way to pass `database` context as header from swagger UI [pinot]

2024-03-22 Thread via GitHub
codecov-commenter commented on PR #12695: URL: https://github.com/apache/pinot/pull/12695#issuecomment-2014553085 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/12695?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&u

Re: [PR] Add a way to pass `database` context as header from swagger UI [pinot]

2024-03-22 Thread via GitHub
shounakmk219 commented on PR #12695: URL: https://github.com/apache/pinot/pull/12695#issuecomment-2014523463 > LGTM, just a note: do you think it may be useful to set the `description` attribute in `ApiKeyAuthDefinition` to indicate this is the database that will be used by default? Or do y

[PR] Add a way to pass `database` context as header from swagger UI [pinot]

2024-03-22 Thread via GitHub
shounakmk219 opened a new pull request, #12695: URL: https://github.com/apache/pinot/pull/12695 # Description This is a best effort attempt to allow passing database context as http header to perform table/schema specific requests. The approach piggy backs on the `@Authorization` API o

Re: [PR] fix float to double type conversion [pinot]

2024-03-22 Thread via GitHub
zhtaoxiang closed pull request #11478: fix float to double type conversion URL: https://github.com/apache/pinot/pull/11478 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To un

Re: [PR] [WIP] Use lombok to simplify code [pinot]

2024-03-22 Thread via GitHub
zhtaoxiang closed pull request #11756: [WIP] Use lombok to simplify code URL: https://github.com/apache/pinot/pull/11756 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu