marregui commented on PR #12668:
URL: https://github.com/apache/pinot/pull/12668#issuecomment-2014724301

   
[benchmark_no_dict_string_compression.txt](https://github.com/apache/pinot/files/14720625/benchmark_no_dict_string_compression.txt)
   
   I finally managed to run the benchmark for strings, numbers are in the 
attached file.
   
   The code had a number of features that prevented it from successfully 
completing on my host. In particular these have been addressed:
   - buffers are instantiated once the trial starts. That is, when `_rowLength` 
is defined.
   - per test, buffers are cleared, populated.
   - the results of compressing, decompressing, just require two buffers in 
total, instead of two buffers per compression type. This is because there is 
one fork with one thread to run all tests.
   - for `_rowLength`, allowing 100 chars per line at most, meant blowing up my 
small host, so I took it down to 30
   
   With all the above the run was successful.
   
   All the abo
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to