davecromberge commented on PR #12685: URL: https://github.com/apache/pinot/pull/12685#issuecomment-2015130624
@Jackie-Jiang I will update the description with more details as to why this change is necessary for Datasketches. Concerning `backward-incompatibility` - I think it is probably more accurate to mark the PR as `upgrade-incompatibility`. This concern only applies to Tuple Sketches, which I believe are unused During the upgrade process, upgraded servers might return accumulator objects to brokers on a current(older) version which still expect sketches. Or, upgraded brokers might expect accumulator objects and servers on the current(older) version might return sketches. This scenario played out previously for Theta sketches and the workaround is to do a runtime type check on intermediate results within the aggregation function - see https://github.com/apache/pinot/pull/12288. This PR only adds this capability for CPC sketches which are more likely to be used, and are in fact being used in our production environment. In order to verify these cases in the compatibility verifier, we need to have more than one server as part of the test cluster (see https://github.com/apache/pinot/issues/12296). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
