gortiz commented on code in PR #12699:
URL: https://github.com/apache/pinot/pull/12699#discussion_r1535344777
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -260,6 +260,8 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
.next() :
CalciteSqlCompiler.compileToBrokerRequest(query).getQuerySource().getTableName();
tableName = _pinotHelixResourceManager.getActualTableName(inputTableName,
httpHeaders.getHeaderString(CommonConstants.DATABASE));
+ } catch (IllegalArgumentException e) {
Review Comment:
Can we change that to emit a more specific exception?
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotQueryResource.java:
##########
@@ -260,6 +260,8 @@ private String getQueryResponse(String query, @Nullable
SqlNode sqlNode, String
.next() :
CalciteSqlCompiler.compileToBrokerRequest(query).getQuerySource().getTableName();
tableName = _pinotHelixResourceManager.getActualTableName(inputTableName,
httpHeaders.getHeaderString(CommonConstants.DATABASE));
+ } catch (IllegalArgumentException e) {
Review Comment:
Can we change this to emit a more specific exception?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
