gortiz commented on code in PR #12673:
URL: https://github.com/apache/pinot/pull/12673#discussion_r1535213030
##########
pinot-clients/pinot-java-client/src/main/java/org/apache/pinot/client/BrokerCache.java:
##########
@@ -190,7 +190,7 @@ protected void updateBrokerData()
public String getBroker(String... tableNames) {
List<String> brokers = null;
- if (tableNames != null) {
+ if (!(tableNames == null || tableNames.length == 0 || tableNames[0] ==
null)) {
Review Comment:
Sorry for not saying that before, but I think the same can be said here.
Either all or none of the actual elements should be compared to null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
