aadilkhalifa commented on PR #12293:
URL: https://github.com/apache/pinot/pull/12293#issuecomment-1913052348
> Thanks @aadilkhalifa for raising the PR!
>
> Can you add some integration tests under
`org.apache.pinot.integration.tests.custom.ArrayTest`
@xiangfu0 I've added the in
aadilkhalifa commented on code in PR #12293:
URL: https://github.com/apache/pinot/pull/12293#discussion_r1468377121
##
pinot-common/src/test/java/org/apache/pinot/common/function/FunctionDefinitionRegistryTest.java:
##
@@ -43,7 +43,7 @@ public class FunctionDefinitionRegistryTes
aadilkhalifa commented on code in PR #12293:
URL: https://github.com/apache/pinot/pull/12293#discussion_r1468377073
##
pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java:
##
@@ -271,6 +271,7 @@ public enum TransformFunctionType {
Operan
Author: mcvsubbu
Date: Sat Jan 27 01:33:58 2024
New Revision: 66884
Log:
Adding vivek iyer as committer
Modified:
release/pinot/KEYS
Modified: release/pinot/KEYS
==
--- release/pinot/KEYS (original)
+++ release/pino
wirybeaver commented on code in PR #12238:
URL: https://github.com/apache/pinot/pull/12238#discussion_r1468198505
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -371,6 +374,50 @@ public void testGetValuesForKeyAndDocs(
chenboat commented on code in PR #12238:
URL: https://github.com/apache/pinot/pull/12238#discussion_r1468183357
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -371,6 +374,50 @@ public void testGetValuesForKeyAndDocs()
klsince commented on code in PR #12324:
URL: https://github.com/apache/pinot/pull/12324#discussion_r1468155291
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -568,6 +568,8 @@ public static class Server {
public static final String CONFIG_O
codecov-commenter commented on PR #12317:
URL: https://github.com/apache/pinot/pull/12317#issuecomment-1912535792
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12317?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 5a382f2e7d Shared aggregations in StarTree (#12164)
add 2acf8ea354 correct errmsg format for Preconditions.check...
klsince merged PR #12327:
URL: https://github.com/apache/pinot/pull/12327
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
wirybeaver commented on code in PR #12238:
URL: https://github.com/apache/pinot/pull/12238#discussion_r1468024267
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -371,6 +374,50 @@ public void testGetValuesForKeyAndDocs(
Jackie-Jiang closed issue #12111: Optimising StarTree metric configuration
URL: https://github.com/apache/pinot/issues/12111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5a382f2e7d Shared aggregations in StarTree (#1216
Jackie-Jiang merged PR #12164:
URL: https://github.com/apache/pinot/pull/12164
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang commented on PR #12164:
URL: https://github.com/apache/pinot/pull/12164#issuecomment-1912492125
@davecromberge Thanks for the contribution! This feature touches the whole
flow from index creation, loading, all the way to query serving. Your work is
super impressive given you ar
chenboat commented on code in PR #12238:
URL: https://github.com/apache/pinot/pull/12238#discussion_r1467981025
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -371,6 +374,50 @@ public void testGetValuesForKeyAndDocs()
chenboat commented on code in PR #12238:
URL: https://github.com/apache/pinot/pull/12238#discussion_r1467980253
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -371,6 +374,50 @@ public void testGetValuesForKeyAndDocs()
klsince opened a new pull request, #12327:
URL: https://github.com/apache/pinot/pull/12327
Preconditions.check... errmsg uses `%s` to format instead of {}, otherwise,
we'd see errmsg like below
```
java.lang.IllegalStateException: Snapshot of validDocIds is required to
preload seg
Jackie-Jiang commented on code in PR #12324:
URL: https://github.com/apache/pinot/pull/12324#discussion_r1467915180
##
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##
@@ -568,6 +568,8 @@ public static class Server {
public static final String CON
codecov-commenter commented on PR #12326:
URL: https://github.com/apache/pinot/pull/12326#issuecomment-1912396535
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12326?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
BrendanStans21 opened a new pull request, #12326:
URL: https://github.com/apache/pinot/pull/12326
* calculate the correct scale when calling getBigDecimal() to prevent the
function throwing a rounding error
--
This is an automated message from the Apache Git Service.
To respond to the mes
davecromberge commented on PR #12164:
URL: https://github.com/apache/pinot/pull/12164#issuecomment-1911956208
> I just pushed a commit with the following changes:
>
> * During query time, resolve the stored type before looking up the
metadata so that no fallback is required
> * Han
tibrewalpratik17 commented on issue #12273:
URL: https://github.com/apache/pinot/issues/12273#issuecomment-1911932076
> why would we do differently for different components?
Because pinot-server / broker can have different headers for the same query
but yeah we can have one general li
tibrewalpratik17 commented on PR #12320:
URL: https://github.com/apache/pinot/pull/12320#issuecomment-1911925334
> why would a download url be empty for a minion task?
There are scenarios when downloadURL can be empty (when deepstore upload
timed out during segment commit or something
codecov-commenter commented on PR #12324:
URL: https://github.com/apache/pinot/pull/12324#issuecomment-1911918294
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12324?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #12325:
URL: https://github.com/apache/pinot/pull/12325#issuecomment-1911847234
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/12325?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
zhtaoxiang opened a new pull request, #12325:
URL: https://github.com/apache/pinot/pull/12325
This is a follow up of https://github.com/apache/pinot/pull/12277. That PR
makes tls keystore/truststore swappable. This PR auto reload tls
keystore/truststore when they are local files.
Wit
KKcorps opened a new pull request, #12324:
URL: https://github.com/apache/pinot/pull/12324
Controller API resource locations are already configurable but Server Admin
API one's are hardcoded.
The PR fixes that by allowing users to change the resource path using
`pinot.server.adminap
28 matches
Mail list logo
