tibrewalpratik17 commented on PR #12320: URL: https://github.com/apache/pinot/pull/12320#issuecomment-1911925334
> why would a download url be empty for a minion task? There are scenarios when downloadURL can be empty (when deepstore upload timed out during segment commit or something). There are ways to enable retries on them but during that period the ZK config has downloadURL has empty. Now if the minion tasks runs during this period, the downloadURL is fetched as null and passed on to task-execution phase where it throws NPE. This patch doesn't allow these segments to go to the task-execution phase itself and stops them in task-generation phase. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
