Jackie-Jiang commented on code in PR #12324: URL: https://github.com/apache/pinot/pull/12324#discussion_r1467915180
########## pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java: ########## @@ -568,6 +568,8 @@ public static class Server { public static final String CONFIG_OF_SWAGGER_USE_HTTPS = "pinot.server.swagger.use.https"; public static final String CONFIG_OF_ADMIN_API_PORT = "pinot.server.adminapi.port"; public static final int DEFAULT_ADMIN_API_PORT = 8097; + public static final String CONFIG_OF_ADMIN_API_RESOURCE_PACKAGES = "pinot.server.adminapi.resource.packages"; Review Comment: Keeping it consistent with controller and broker ```suggestion public static final String CONFIG_OF_SERVER_RESOURCE_PACKAGES = "pinot.server.restlet.api.resource.packages"; ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org