davecromberge commented on PR #12164: URL: https://github.com/apache/pinot/pull/12164#issuecomment-1911956208
> I just pushed a commit with the following changes: > > * During query time, resolve the stored type before looking up the metadata so that no fallback is required > * Handle backward-compatibility for old star-tree index where function might not be stored type > * Add a test for querying non-stored type > > I did a commit instead of leaving comments because the code is spread in multiple classes and is kind of hard to explain. Let me know if the commit looks good. Thank you @Jackie-Jiang, I appreciate you taking the time to contribute further to this PR. I have reviewed your commit and it all looks good. I can understand why the changes you made might have been difficult to discuss over the PR. In particular, the areas affected within the query planner and underlying index reader were parts of the platform that I am less familiar with and it has been a good learning exercise to see your changes in this context! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
