tibrewalpratik17 commented on issue #12273: URL: https://github.com/apache/pinot/issues/12273#issuecomment-1911932076
> why would we do differently for different components? Because pinot-server / broker can have different headers for the same query but yeah we can have one general list for all components as well. > union both; (could you elaborate on the union-distinct? i can only think of adding instead of removing) This i proposed just in case we want to remove some header due to any manual misconfiguration or anything. In the case, if ZK has it and conf-file does not; doing a union will pick the header again. Better to expose an API for removing from ZK then. So to summarise the entire flow: - first load the headers listed in the cluster zk conf - then load the component level conf - do a union To add a new header, use an controller API to add it to ZK conf. Restart and then it will be picked up -- no need to necessarily change the conf file here. To remove a header (just in case), use controller API to remove from ZK conf. Remove from conf file as well. Restart. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
