codecov-commenter commented on PR #11710:
URL: https://github.com/apache/pinot/pull/11710#issuecomment-1740388935
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11710?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
gortiz commented on PR #11710:
URL: https://github.com/apache/pinot/pull/11710#issuecomment-1740385931
I've added some notes, but I think the PR is in good shape
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340953692
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java:
##
@@ -602,6 +602,16 @@ public void testTimeFunc(boolean
gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340952925
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
processQueryAndSerialize(ServerQueryRequ
gortiz commented on code in PR #11710:
URL: https://github.com/apache/pinot/pull/11710#discussion_r1340952382
##
pinot-core/src/main/java/org/apache/pinot/core/query/scheduler/QueryScheduler.java:
##
@@ -168,6 +169,19 @@ protected byte[]
processQueryAndSerialize(ServerQueryRequ
codecov-commenter commented on PR #11709:
URL: https://github.com/apache/pinot/pull/11709#issuecomment-1740361099
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11709?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
xiangfu0 commented on code in PR #11574:
URL: https://github.com/apache/pinot/pull/11574#discussion_r1340932616
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -549,6 +555,69 @@ protected void configure() {
_serviceStatusCall
dang-stripe commented on PR #11650:
URL: https://github.com/apache/pinot/pull/11650#issuecomment-1740356183
Yes, we still want to use the global sequence ID which isn't supported by
the `FixedSegmentNameGenerator`. Another option here is to update
`FixedSegmentNameGenerator` to support appe
vvivekiyer opened a new pull request, #11710:
URL: https://github.com/apache/pinot/pull/11710
When server responds for a query with a large response, the broker can
potentially crash with direct memory OOM.
In PR https://github.com/apache/pinot/pull/11496 - a fix was added to
restar
zhtaoxiang opened a new pull request, #11709:
URL: https://github.com/apache/pinot/pull/11709
label: `performance`
update initial capacity to HashUtil.getHashMapCapacity(desired size) to
avoid map resizing
--
This is an automated message from the Apache Git Service.
To respond
This is an automated email from the ASF dual-hosted git repository.
saurabhd336 pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 54a1ca01b5 Allow GcsPinotFS to work with gra
saurabhd336 merged PR #11655:
URL: https://github.com/apache/pinot/pull/11655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.
swaminathanmanish commented on PR #11650:
URL: https://github.com/apache/pinot/pull/11650#issuecomment-1740308268
> Related to #11649
>
> We use the `normalizedDate` segment name generator for an append table w/
a time column. The generators add a min/max time value to the segment nam
tibrewalpratik17 commented on code in PR #11705:
URL: https://github.com/apache/pinot/pull/11705#discussion_r1340861053
##
pinot-broker/src/test/java/org/apache/pinot/broker/broker/BrokerManagedAsyncExecutorProviderTest.java:
##
@@ -92,6 +94,23 @@ public void testGet()
Bl
dang-stripe commented on PR #11650:
URL: https://github.com/apache/pinot/pull/11650#issuecomment-1740236292
@swaminathanmanish thanks for reviewing! updated the description to include
motivation and responded to your comment
--
This is an automated message from the Apache Git Service.
To
dang-stripe commented on code in PR #11650:
URL: https://github.com/apache/pinot/pull/11650#discussion_r1340840866
##
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskRunner.java:
#
xiangfu0 merged PR #11707:
URL: https://github.com/apache/pinot/pull/11707
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
This is an automated email from the ASF dual-hosted git repository.
xiangfu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new e08e66c399 correct default log4j2 config file pa
walterddr commented on issue #11651:
URL: https://github.com/apache/pinot/issues/11651#issuecomment-1740146801
here is a proposal for creating lookup join support in the v2 engine:
https://docs.google.com/document/d/1cyFrW21MlcbHEEfl46paKRs6v6qHzwOZbIsnFL7UVnw/edit#heading=h.xdbe7h7na0kx
Jackie-Jiang commented on PR #11708:
URL: https://github.com/apache/pinot/pull/11708#issuecomment-1740144719
@siddharthteotia @jackjlli Can you take a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Jackie-Jiang commented on code in PR #11705:
URL: https://github.com/apache/pinot/pull/11705#discussion_r1340762657
##
pinot-broker/src/test/java/org/apache/pinot/broker/broker/BrokerManagedAsyncExecutorProviderTest.java:
##
@@ -92,6 +94,23 @@ public void testGet()
Blocki
kirkrodrigues commented on code in PR #11604:
URL: https://github.com/apache/pinot/pull/11604#discussion_r1340749635
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -233,6 +210,83 @@ public void testLargeIndex()
}
chenboat commented on code in PR #11604:
URL: https://github.com/apache/pinot/pull/11604#discussion_r1340745847
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/JsonIndexTest.java:
##
@@ -233,6 +210,83 @@ public void testLargeIndex()
}
}
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 15988f6016 add ignored test capability (#11703)
15
walterddr merged PR #11703:
URL: https://github.com/apache/pinot/pull/11703
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
jasperjiaguo commented on issue #11631:
URL: https://github.com/apache/pinot/issues/11631#issuecomment-1740106821
fixed https://github.com/apache/pinot/pull/11700
https://docs.pinot.apache.org/configuration-reference/functions/arg_min-arg_max
--
This is an automated message from the Apach
codecov-commenter commented on PR #11708:
URL: https://github.com/apache/pinot/pull/11708#issuecomment-1740068915
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11708?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
tibrewalpratik17 commented on code in PR #11705:
URL: https://github.com/apache/pinot/pull/11705#discussion_r1340704103
##
pinot-broker/src/test/java/org/apache/pinot/broker/broker/BrokerManagedAsyncExecutorProviderTest.java:
##
@@ -92,6 +94,23 @@ public void testGet()
Bl
Jackie-Jiang commented on code in PR #11705:
URL: https://github.com/apache/pinot/pull/11705#discussion_r1340700894
##
pinot-broker/src/test/java/org/apache/pinot/broker/broker/BrokerManagedAsyncExecutorProviderTest.java:
##
@@ -92,6 +94,23 @@ public void testGet()
Blocki
Jackie-Jiang commented on issue #11704:
URL: https://github.com/apache/pinot/issues/11704#issuecomment-1740050114
Unfortunately I cannot tell what is causing the decompression failure by the
stack trace itself.
To debug the issue, we need to dig into the problematic segment and find the
siddharthteotia commented on PR #11699:
URL: https://github.com/apache/pinot/pull/11699#issuecomment-1740042082
@Jackie-Jiang - @vvivekiyer and I will provide you with the context. Will
setup something soon.
TLDR - We have started thinking about the scheduling sub-problem described
Jackie-Jiang merged PR #11695:
URL: https://github.com/apache/pinot/pull/11695
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jlli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 81e1143f39 refactor code and doc occurrences of arg
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new c642db0666 use SlidingTimeWindowArrayReservoir in
jackjlli merged PR #11700:
URL: https://github.com/apache/pinot/pull/11700
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apa
jackjlli commented on code in PR #11574:
URL: https://github.com/apache/pinot/pull/11574#discussion_r1340691844
##
pinot-controller/src/main/java/org/apache/pinot/controller/BaseControllerStarter.java:
##
@@ -549,6 +555,69 @@ protected void configure() {
_serviceStatusCall
Jackie-Jiang commented on PR #11699:
URL: https://github.com/apache/pinot/pull/11699#issuecomment-1740035068
@vvivekiyer I don't know the exact race condition, but the test in
`PrioritySchedulerTest` was disabled due to race condition. Use this class with
cautious because it is not verified
codecov-commenter commented on PR #11707:
URL: https://github.com/apache/pinot/pull/11707#issuecomment-1740034768
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11707?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
tibrewalpratik17 opened a new pull request, #11708:
URL: https://github.com/apache/pinot/pull/11708
As per discussion in
https://github.com/apache/pinot/pull/11437#discussion_r1326698944 adding more
information to `RequestContext` class. Most of the fields already existed in
`BrokerRespons
swaminathanmanish commented on code in PR #11650:
URL: https://github.com/apache/pinot/pull/11650#discussion_r1340683133
##
pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentGenerationTaskRunner.java:
###
This is an automated email from the ASF dual-hosted git repository.
siddteotia pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 9ead3ff5bc Upgrade Avro dependency to 1.10.2 (#11698)
add d78682e291 Make constructor and functions public to
siddharthteotia merged PR #11699:
URL: https://github.com/apache/pinot/pull/11699
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pi
This is an automated email from the ASF dual-hosted git repository.
sajjad pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from cf8fd93759 MultiValue VarByte V4 index writer and consolidate V4
reader for all types (#11674)
add 9ead3ff5bc Upg
sajjad-moradi merged PR #11698:
URL: https://github.com/apache/pinot/pull/11698
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pino
zhtaoxiang opened a new pull request, #11707:
URL: https://github.com/apache/pinot/pull/11707
label: `bugfix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
walterddr commented on issue #10381:
URL: https://github.com/apache/pinot/issues/10381#issuecomment-1739978297
CC @gortiz who is also interested in null handling work
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
walterddr closed issue #11691: [multistage] IS NULL/ IS NOT NULL getting
skipped from the queries using multistage
URL: https://github.com/apache/pinot/issues/11691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
walterddr commented on issue #11691:
URL: https://github.com/apache/pinot/issues/11691#issuecomment-1739977638
closing this as duplicate of #10381
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
walterddr commented on PR #10423:
URL: https://github.com/apache/pinot/pull/10423#issuecomment-1739975940
closing this one and creating a new one (design doc shared in #10381)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
walterddr closed pull request #10423: [multistage] proper support for
column-level null handling
URL: https://github.com/apache/pinot/pull/10423
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the s
walterddr commented on issue #10381:
URL: https://github.com/apache/pinot/issues/10381#issuecomment-1739977403
here is a quick design doc:
https://docs.google.com/document/d/16slt8TEfhJjDCjbE7K6za9hrB5WagiuKscFzod2Oib8/edit
TL;DR
similar to the POC in #10423 and following the comme
codecov-commenter commented on PR #11705:
URL: https://github.com/apache/pinot/pull/11705#issuecomment-1739940414
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11705?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang opened a new issue, #11706:
URL: https://github.com/apache/pinot/issues/11706
When a group-by query does not have order-by on the aggregate column, we
don't need to keep more groups than the LIMIT because the order-by value won't
change. We can maintain a heap (PriorityQueue) o
tibrewalpratik17 opened a new pull request, #11705:
URL: https://github.com/apache/pinot/pull/11705
label
- `testing`
This is a small patch to add more unit tests for broker managed async
executor provider class.
--
This is an automated message from the Apache Git Service.
To re
Jackie-Jiang closed issue #8697: Proper NULL value support in Pinot
URL: https://github.com/apache/pinot/issues/8697
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
rohityadav1993 commented on issue #11704:
URL: https://github.com/apache/pinot/issues/11704#issuecomment-1739784705
I do have the raw string that is being persisted. Is there a way to figure
out which special character could be causing this?
--
This is an automated message from the Apache
vvivekiyer commented on PR #11699:
URL: https://github.com/apache/pinot/pull/11699#issuecomment-1739782509
@Jackie-Jiang
We are not using the PriorityBasedSchedulers. Just curious - can you point
me to the race condition?
About this change - We have a use case in Linkedin where w
Jackie-Jiang merged PR #11674:
URL: https://github.com/apache/pinot/pull/11674
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new cf8fd93759 MultiValue VarByte V4 index writer and
codecov-commenter commented on PR #11703:
URL: https://github.com/apache/pinot/pull/11703#issuecomment-1739764974
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11703?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
Jackie-Jiang commented on issue #11704:
URL: https://github.com/apache/pinot/issues/11704#issuecomment-1739758632
Do you have the raw data used to generate the segment? From what I can tell
from the stack trace, it might hit some bug in snappy library. Do you have
special character in your
Jackie-Jiang commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1340481197
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -73,10 +73,12 @@ public
Jackie-Jiang commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1340479513
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -74,7 +74,7 @@ public Ge
Jackie-Jiang commented on PR #11575:
URL: https://github.com/apache/pinot/pull/11575#issuecomment-1739742639
@siddharthteotia Did Gonzalo address your concern?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
Jackie-Jiang commented on code in PR #11575:
URL: https://github.com/apache/pinot/pull/11575#discussion_r1340470598
##
pinot-core/src/test/java/org/apache/pinot/core/transport/QueryRoutingTest.java:
##
@@ -77,9 +78,16 @@ public void setUp() {
_requestCount = 0;
}
+ @A
sajjad-moradi commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1340470864
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -74,7 +74,7 @@ public G
sajjad-moradi commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1340461420
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -74,7 +74,7 @@ public G
Jackie-Jiang commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1340446845
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -74,7 +74,7 @@ public Ge
rohityadav1993 opened a new issue, #11704:
URL: https://github.com/apache/pinot/issues/11704
This happens only for a few rows and only in offline segments. The column is
single value string with raw forward encoding
```
...
...
"noDictionaryColumns": [
"compresse
Jackie-Jiang commented on code in PR #11698:
URL: https://github.com/apache/pinot/pull/11698#discussion_r1340444844
##
pinot-plugins/pinot-input-format/pinot-avro-base/src/main/java/org/apache/pinot/plugin/inputformat/avro/AvroRecordExtractor.java:
##
@@ -74,7 +74,7 @@ public Ge
walterddr opened a new pull request, #11703:
URL: https://github.com/apache/pinot/pull/11703
- add flag to run ignored tests cases
- doesn't support run ignored tables b/c we can't load those table
during `setUp`
- fix several ignored where we already supports now.
--
This is a
jugomezv commented on issue #11632:
URL: https://github.com/apache/pinot/issues/11632#issuecomment-1739650460
Yes should be an easy change. I had this as follow up but have other tasks
at work now. @snleee we can let @cypherean take a stab? keep me in the loop
for reviews
--
This is an
walterddr commented on code in PR #11404:
URL: https://github.com/apache/pinot/pull/11404#discussion_r1340340485
##
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##
@@ -572,4 +573,10 @@ public Object[][] useV2QueryEngine() {
saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340339841
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java:
##
@@ -81,13 +81,17 @@ public static Forwa
saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340323638
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java:
##
@@ -113,6 +116,156 @@ pu
saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340325494
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java:
##
@@ -113,6 +116,156 @@ pu
saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340322049
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/readers/forward/VarByteChunkForwardIndexReaderV4.java:
##
@@ -113,6 +116,156 @@ pu
saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340320116
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java:
##
@@ -142,6 +144,51 @@ public void putByt
saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340319747
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/io/writer/impl/VarByteChunkForwardIndexWriterV4.java:
##
@@ -142,6 +144,51 @@ public void putByt
codecov-commenter commented on PR #11702:
URL: https://github.com/apache/pinot/pull/11702#issuecomment-1738831483
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11702?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
gortiz opened a new pull request, #11702:
URL: https://github.com/apache/pinot/pull/11702
This PR tries to blindly update from Spark 3.2.4 to 3.5.0.
See https://github.com/apache/pinot/issues/11701
--
This is an automated message from the Apache Git Service.
To respond to the messag
gortiz opened a new issue, #11701:
URL: https://github.com/apache/pinot/issues/11701
This issue is created to analyze whether we can upgrade our Spark 3.x
dependencies to 3.5.0.
Apache Pinot connects to Apache Spark in two different types of modules:
- batch ingestion plugins (modu
gortiz commented on PR #11695:
URL: https://github.com/apache/pinot/pull/11695#issuecomment-1738615579
> Thanks for raising this and providing the readings! Curious how you decide
to configure the sliding window to be 15 minutes? What is the side effect of
that?
I've just decided to
83 matches
Mail list logo
