saurabhd336 commented on code in PR #11674:
URL: https://github.com/apache/pinot/pull/11674#discussion_r1340339841
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/forward/ForwardIndexReaderFactory.java:
##########
@@ -81,13 +81,17 @@ public static ForwardIndexReader
createRawIndexReader(PinotDataBuffer dataBuffer
? new FixedBytePower2ChunkSVForwardIndexReader(dataBuffer,
storedType)
: new FixedByteChunkSVForwardIndexReader(dataBuffer, storedType);
} else {
- return version == VarByteChunkForwardIndexWriterV4.VERSION ? new
VarByteChunkSVForwardIndexReaderV4(dataBuffer,
- storedType) : new VarByteChunkSVForwardIndexReader(dataBuffer,
storedType);
+ return version == VarByteChunkForwardIndexWriterV4.VERSION ? new
VarByteChunkForwardIndexReaderV4(
Review Comment:
This logic is quite convoluted. I've updated to make it shorter, please have
a look. We may think about refactoring VarByteChunkSVForwardIndexReader and
VarByteChunkMVForwardIndexReader to be a single class similar to the new v4
reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
