[pinot] branch master updated: use SlidingTimeWindowArrayReservoir instead of default ExponentiallyDecayingReservoir in dropwizard metrics (#11695)

[jackie]

This is an automated email from the ASF dual-hosted git repository.

jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git


The following commit(s) were added to refs/heads/master by this push:
     new c642db0666 use SlidingTimeWindowArrayReservoir instead of default 
ExponentiallyDecayingReservoir in dropwizard metrics (#11695)
c642db0666 is described below

commit c642db066608769ea3131572945883b0b0e7b780
Author: Gonzalo Ortiz Jaureguizar <gor...@users.noreply.github.com>
AuthorDate: Thu Sep 28 23:41:34 2023 +0200

    use SlidingTimeWindowArrayReservoir instead of default 
ExponentiallyDecayingReservoir in dropwizard metrics (#11695)
---
 .../plugin/metrics/dropwizard/DropwizardMetricsRegistry.java  | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git 
a/pinot-plugins/pinot-metrics/pinot-dropwizard/src/main/java/org/apache/pinot/plugin/metrics/dropwizard/DropwizardMetricsRegistry.java
 
b/pinot-plugins/pinot-metrics/pinot-dropwizard/src/main/java/org/apache/pinot/plugin/metrics/dropwizard/DropwizardMetricsRegistry.java
index 3f8f270e5c..ceb4e0970e 100644
--- 
a/pinot-plugins/pinot-metrics/pinot-dropwizard/src/main/java/org/apache/pinot/plugin/metrics/dropwizard/DropwizardMetricsRegistry.java
+++ 
b/pinot-plugins/pinot-metrics/pinot-dropwizard/src/main/java/org/apache/pinot/plugin/metrics/dropwizard/DropwizardMetricsRegistry.java
@@ -18,9 +18,12 @@
  */
 package org.apache.pinot.plugin.metrics.dropwizard;
 
+import com.codahale.metrics.Histogram;
 import com.codahale.metrics.Metric;
 import com.codahale.metrics.MetricRegistry;
 import com.codahale.metrics.MetricRegistryListener;
+import com.codahale.metrics.SlidingTimeWindowArrayReservoir;
+import com.codahale.metrics.Timer;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.concurrent.TimeUnit;
@@ -66,12 +69,16 @@ public class DropwizardMetricsRegistry implements 
PinotMetricsRegistry {
 
   @Override
   public PinotTimer newTimer(PinotMetricName name, TimeUnit durationUnit, 
TimeUnit rateUnit) {
-    return new 
DropwizardTimer(_metricRegistry.timer(name.getMetricName().toString()));
+    Timer timer = _metricRegistry.timer(name.getMetricName().toString(),
+        () -> new Timer(new SlidingTimeWindowArrayReservoir(15, 
TimeUnit.MINUTES)));
+    return new DropwizardTimer(timer);
   }
 
   @Override
   public PinotHistogram newHistogram(PinotMetricName name, boolean biased) {
-    return new 
DropWizardHistogram(_metricRegistry.histogram(name.getMetricName().toString()));
+    Histogram histogram = 
_metricRegistry.histogram(name.getMetricName().toString(),
+        () -> new Histogram(new SlidingTimeWindowArrayReservoir(15, 
TimeUnit.MINUTES)));
+    return new DropWizardHistogram(histogram);
   }
 
   @Override


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org