walterddr commented on code in PR #11404:
URL: https://github.com/apache/pinot/pull/11404#discussion_r1340340485


##########
pinot-integration-test-base/src/test/java/org/apache/pinot/integration/tests/ClusterTest.java:
##########
@@ -572,4 +573,10 @@ public Object[][] useV2QueryEngine() {
         {true}
     };
   }
+
+  protected void notSupportedInV2() {

Review Comment:
   per discussion with @gortiz This was added to skip V2 when there's test 
failure. however some test cases actually sequentially ran though the queries. 
so if the earlier one fails. there's no way to capture the latter ones. 
   
   we should switch to a provider pattern otherwise the sequential query run 
will not capture enough



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to