walterddr commented on issue #10381: URL: https://github.com/apache/pinot/issues/10381#issuecomment-1739977403
here is a quick design doc: https://docs.google.com/document/d/16slt8TEfhJjDCjbE7K6za9hrB5WagiuKscFzod2Oib8/edit TL;DR similar to the POC in #10423 and following the comments from @ankitsultana and @Jackie-Jiang 1. add `_isNullableField` field in `FieldSpec`, with a default value as false. 2. When resolving whether a column is nullable the migration transition plan is as follow - When column level nullability is not configured, default to false - Matches current multi-stage engine behavior - For single-stage engine, behavior doesn’t change either by following query time option flag - When column level nullability is configured (explicitly to either true or false), only if the table level nullability is turned on the following applies - Multi-stage engine registers columns with explicitly true setting as nullable - Single-stage engine doesn’t change behavior -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
