INNOCENT-BOY commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1246134976
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##
@@ -359,7 +359,8 @@ private void validateSchemaInte
INNOCENT-BOY commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1246134976
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##
@@ -359,7 +359,8 @@ private void validateSchemaInte
INNOCENT-BOY commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1246134976
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##
@@ -359,7 +359,8 @@ private void validateSchemaInte
shenyu0127 commented on code in PR #10999:
URL: https://github.com/apache/pinot/pull/10999#discussion_r1246133357
##
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/MultiNodesOfflineClusterIntegrationTest.java:
##
@@ -178,11 +178,12 @@ private void testC
shwin commented on issue #10986:
URL: https://github.com/apache/pinot/issues/10986#issuecomment-1612436438
in case it's helpful, here's some column metadata for the column in question:
```
"segment.start.time": "1620663024000",
"segment.time.unit": "MILLISECONDS",
"columns": [
shwin commented on issue #10986:
URL: https://github.com/apache/pinot/issues/10986#issuecomment-1612411307
Trying it again, I noticed that the `numSegmentsMatched` is 1 lower in the
`=` EQ case than the >= case.
--
This is an automated message from the Apache Git Service.
To respo
ankitsultana commented on PR #10815:
URL: https://github.com/apache/pinot/pull/10815#issuecomment-1612406620
> Do we need to clean up tmp files periodically, or just when the controller
starts?
To add to @wirybeaver 's response, we will need to add a periodic job for
this clean-up. T
shwin commented on issue #10986:
URL: https://github.com/apache/pinot/issues/10986#issuecomment-1612404167
> When you run the second query, is it possible that the first segment just
expired?
Hmm, not sure what you mean here; I can repeatedly run both these queries
and get consistent
dang-stripe opened a new issue, #11001:
URL: https://github.com/apache/pinot/issues/11001
we recently had some dns instability issues w/ our kafka cluster that caused
consumer creation to fail since it couldn't resolve broker dns. while
investigating, we noticed that we were creating N cons
codecov-commenter commented on PR #11000:
URL: https://github.com/apache/pinot/pull/11000#issuecomment-1612381016
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/11000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
codecov-commenter commented on PR #10999:
URL: https://github.com/apache/pinot/pull/10999#issuecomment-1612362553
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10999?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
itschrispeck opened a new pull request, #11000:
URL: https://github.com/apache/pinot/pull/11000
wip PR for adding support for MV cols with lucene index
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Jackie-Jiang commented on issue #10986:
URL: https://github.com/apache/pinot/issues/10986#issuecomment-1612352457
Based on the query plan, seems range index doesn't handle EQ predicate
properly. Which Pinot version are you running? When you run the second query,
is it possible that the firs
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new fc26d6d897 Fix the NULL ordering in TableResizer
Jackie-Jiang merged PR #10939:
URL: https://github.com/apache/pinot/pull/10939
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
Jackie-Jiang merged PR #10997:
URL: https://github.com/apache/pinot/pull/10997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from ed4774c5d9 Use pinot-query-planner utils to extract table names in
pinot-controller (#10873)
add db0f3dcb73 Fix a
Jackie-Jiang opened a new pull request, #10999:
URL: https://github.com/apache/pinot/pull/10999
Got another possible exception message, so removed the message check as it
is not important
```
MultiNodesOfflineClusterIntegrationTest.testServerHardFailure:150->testCountStarQuery:183
wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1245969155
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,47 @@ public SuccessResponse deleteSe
wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1245956913
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,52 @@ public SuccessResponse deleteSe
Jackie-Jiang commented on code in PR #10990:
URL: https://github.com/apache/pinot/pull/10990#discussion_r1245955420
##
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreatorTest.java:
##
@@ -174,21 +202,52 @@ private sta
This is an automated email from the ASF dual-hosted git repository.
rongr pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
from 5c3cf01cd8 do not readd lucene readers to queue if segment is
destroyed (#10989)
add ed4774c5d9 Use pinot-query-pl
walterddr merged PR #10873:
URL: https://github.com/apache/pinot/pull/10873
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.ap
Jackie-Jiang commented on issue #10974:
URL: https://github.com/apache/pinot/issues/10974#issuecomment-1612272348
Yes, we don't need the `-schemaName` option. `schemaName` is embedded in the
table config, and is optional. When it is configured, we look up the schema
using `schemaName`; when
walterddr commented on code in PR #10991:
URL: https://github.com/apache/pinot/pull/10991#discussion_r1245949367
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSchemaRestletResource.java:
##
@@ -359,7 +359,8 @@ private void validateSchemaInterna
Jackie-Jiang commented on code in PR #10891:
URL: https://github.com/apache/pinot/pull/10891#discussion_r1245946338
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/creator/impl/SegmentColumnarIndexCreator.java:
##
@@ -83,7 +83,7 @@ public class Segmen
deemoliu commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1245918886
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegm
Jackie-Jiang commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1245939233
##
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##
@@ -41,6 +41,9 @@ private DataTypeConversionFunctions()
Jackie-Jiang commented on issue #10907:
URL: https://github.com/apache/pinot/issues/10907#issuecomment-1612255465
> Would this solution mean that if a user enables Null Values on an existing
table they have to configure what columns will support Nulls and then we treat
the default value as
Jackie-Jiang commented on issue #10980:
URL: https://github.com/apache/pinot/issues/10980#issuecomment-1612251059
This doesn't seem to be the root cause of the failure. All these classes are
`Helix` classes, not Pinot classes. Can you check if there are other error logs
before this, or if t
codecov-commenter commented on PR #10997:
URL: https://github.com/apache/pinot/pull/10997#issuecomment-1612246794
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10997?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
tibrewalpratik17 commented on PR #10993:
URL: https://github.com/apache/pinot/pull/10993#issuecomment-1612237184
cc @chenboat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
egalpin opened a new issue, #10998:
URL: https://github.com/apache/pinot/issues/10998
This idea is not mine, but rather was mentioned by @npawar during the '22
RTA Summit video covering Tiered Storage[1]. The context in the video was using
block-level bloom filters to enable loading of bloc
Jackie-Jiang closed issue #10976: _luceneRealtimeReaders is constantly
increasing, causing text index creation lag
URL: https://github.com/apache/pinot/issues/10976
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 5c3cf01cd8 do not readd lucene readers to queue i
Jackie-Jiang merged PR #10989:
URL: https://github.com/apache/pinot/pull/10989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
mcvsubbu commented on issue #10996:
URL: https://github.com/apache/pinot/issues/10996#issuecomment-1612227779
On your questions:
Stream level consumption basically involves a single server consuming all
partitions of the stream. Therefore there are no guarantees that all replicas
of the
shenyu0127 opened a new pull request, #10997:
URL: https://github.com/apache/pinot/pull/10997
The test is flaky because we store the column as float and do a `SELECT
WHERE column = Float.doubleValue()` query.
We can reproduce a failed test by changing line 224 to `Float baseValue =
0
mcvsubbu commented on issue #10996:
URL: https://github.com/apache/pinot/issues/10996#issuecomment-1612224205
Proposal accepted to sunset stream level consumption. if it makes sense for
some unpartitioned stream later, they can implement/resurrect things as needed
(better start fresh implem
mcvsubbu commented on issue #10996:
URL: https://github.com/apache/pinot/issues/10996#issuecomment-1612223488
Related Issue #8804
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
wirybeaver commented on PR #10815:
URL: https://github.com/apache/pinot/pull/10815#issuecomment-1612220804
> Do we need to clean up tmp files periodically, or just when the controller
starts? Will controller create extra tmp files during the regular life cycle
without shut down?
Hi J
mcvsubbu commented on issue #10996:
URL: https://github.com/apache/pinot/issues/10996#issuecomment-1612220585
cc: @sajjad-moradi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
Jackie-Jiang commented on issue #10975:
URL: https://github.com/apache/pinot/issues/10975#issuecomment-1612204456
cc @atris
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
Jackie-Jiang commented on issue #10974:
URL: https://github.com/apache/pinot/issues/10974#issuecomment-1612203080
Great suggestion!
FYI, `schemaName` is not mandatory in the table config (actually we
recommend not putting it), and by default schema name should be the same as
table name.
Jackie-Jiang commented on PR #10815:
URL: https://github.com/apache/pinot/pull/10815#issuecomment-1612198919
Do we need to clean up tmp files periodically, or just when the controller
starts? Will controller create extra tmp files during the regular life cycle
without shut down?
--
This
navina commented on issue #10996:
URL: https://github.com/apache/pinot/issues/10996#issuecomment-1612197810
cc: @Jackie-Jiang @mayankshriv @npawar @mcvsubbu @yupeng9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
navina opened a new issue, #10996:
URL: https://github.com/apache/pinot/issues/10996
Issue is to open-up a discussion around:
1. Why and in what use-cases, does it make sense to use the stream level
consumption model in Pinot ?
2. What are the semantics offered by the stream level cons
JeffBolle opened a new pull request, #10995:
URL: https://github.com/apache/pinot/pull/10995
fixes #10994. Adds Metadata parsing to Pulsar sources following the pattern
of #9224.
@navina
--
This is an automated message from the Apache Git Service.
To respond to the message, please
JeffBolle opened a new issue, #10994:
URL: https://github.com/apache/pinot/issues/10994
Following up on PR #9224, metadata from Pulsar sources should be available
in Pinot.
I will also have a PR to address this issue.
--
This is an automated message from the Apache Git Service.
To
Jackie-Jiang commented on issue #10973:
URL: https://github.com/apache/pinot/issues/10973#issuecomment-1612143722
I think the race condition happens because moving segment file to deep store
and updating ZK metadata cannot be done atomically. There is another potential
race condition: crc i
Jackie-Jiang commented on code in PR #10927:
URL: https://github.com/apache/pinot/pull/10927#discussion_r1245782927
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##
@@ -254,7 +256,9 @@ protected void
navina closed issue #10452: Support delete record with upsert table
URL: https://github.com/apache/pinot/issues/10452
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubsc
navina commented on issue #10452:
URL: https://github.com/apache/pinot/issues/10452#issuecomment-1612107496
Resolving this issue. Documentation updated here -
https://docs.pinot.apache.org/basics/data-import/upsert#delete-column
--
This is an automated message from the Apache Git Service
swaminathanmanish commented on code in PR #10987:
URL: https://github.com/apache/pinot/pull/10987#discussion_r1245754119
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentRowComputer.java:
##
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache So
This is an automated email from the ASF dual-hosted git repository.
jackie pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 82252ed843 [Clean up] Do not count DISTINCT as ag
Jackie-Jiang merged PR #10985:
URL: https://github.com/apache/pinot/pull/10985
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot
wirybeaver closed issue #10981: json_extract_scalar times out when the
expression contains index
URL: https://github.com/apache/pinot/issues/10981
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wirybeaver commented on issue #10981:
URL: https://github.com/apache/pinot/issues/10981#issuecomment-1611972584
version 0.12 works fine. Close this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
snleee commented on code in PR #10987:
URL: https://github.com/apache/pinot/pull/10987#discussion_r1245532994
##
pinot-core/src/main/java/org/apache/pinot/core/segment/processing/framework/SegmentRowComputer.java:
##
@@ -0,0 +1,28 @@
+/**
+ * Licensed to the Apache Software Foun
walterddr commented on code in PR #10918:
URL: https://github.com/apache/pinot/pull/10918#discussion_r1245506688
##
pinot-integration-tests/src/test/resources/examples/batch/tpch/customer/customer_offline_table_config.json:
##
@@ -0,0 +1,27 @@
+{
Review Comment:
Let's make t
codecov-commenter commented on PR #10993:
URL: https://github.com/apache/pinot/pull/10993#issuecomment-1611746937
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10993?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
robertzych commented on code in PR #10463:
URL: https://github.com/apache/pinot/pull/10463#discussion_r1245482962
##
pinot-server/src/main/java/org/apache/pinot/server/api/resources/TablesResource.java:
##
@@ -425,7 +425,7 @@ public Response downloadSegment(
public Response d
walterddr commented on issue #10992:
URL: https://github.com/apache/pinot/issues/10992#issuecomment-1611731906
this is a GOOD point!
as of now, the entire v1 execution (all the way to the
instanceResponseBlock) is considered as a "single-operator" of V2 (this
execution is encapsulat
tibrewalpratik17 opened a new pull request, #10993:
URL: https://github.com/apache/pinot/pull/10993
labels:
1. `bugfix`
2. `backward-incompatible`
We found an issue with `listInstanceOrToggleTenantState` endpoint today in
our production.
- We do a POST operation in
summerhasama-stripe commented on code in PR #10983:
URL: https://github.com/apache/pinot/pull/10983#discussion_r1245377750
##
pinot-spi/src/test/java/org/apache/pinot/spi/stream/StreamDataDecoderImplTest.java:
##
@@ -41,7 +41,7 @@ public void testDecodeValueOnly()
messageDe
This is an automated email from the ASF dual-hosted git repository.
xbli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/pinot.git
The following commit(s) were added to refs/heads/master by this push:
new 45a32eaaad Add a PrioritizedFilterOperator (#10953)
klsince merged PR #10953:
URL: https://github.com/apache/pinot/pull/10953
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apac
jackluo923 commented on issue #10981:
URL: https://github.com/apache/pinot/issues/10981#issuecomment-1611358390
Based on my experimentation and the version of Pinot you are currently
using, it appears that there may be difficulties when using json_extract_scalar
to extract values from JSON
shounakmk219 commented on code in PR #10969:
URL: https://github.com/apache/pinot/pull/10969#discussion_r1245149485
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3148,6 +3137,31 @@ public PinotResourceManagerRespo
shounakmk219 commented on code in PR #10969:
URL: https://github.com/apache/pinot/pull/10969#discussion_r1245142369
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java:
##
@@ -390,4 +391,33 @@ public SuccessResponse updat
shounakmk219 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1245121270
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##
@@ -83,7 +86,11 @@ public MultipleTreesBuilde
shounakmk219 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1245119124
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##
@@ -104,7 +111,11 @@ public MultipleTreesBuil
shounakmk219 commented on code in PR #10905:
URL: https://github.com/apache/pinot/pull/10905#discussion_r1245114343
##
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/startree/v2/builder/MultipleTreesBuilder.java:
##
@@ -115,13 +126,38 @@ public MultipleTreesBui
ankitsultana opened a new issue, #10992:
URL: https://github.com/apache/pinot/issues/10992
Looks like we are making request-ids unique at stage level for the leaf
stage execution.
This doesn't fit neatly with the concept of request-id because we'd want a
single request-id for tracing
codecov-commenter commented on PR #10991:
URL: https://github.com/apache/pinot/pull/10991#issuecomment-1610931375
##
[Codecov](https://app.codecov.io/gh/apache/pinot/pull/10991?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
R
saurabhd336 commented on code in PR #10969:
URL: https://github.com/apache/pinot/pull/10969#discussion_r1244790349
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3148,6 +3137,31 @@ public PinotResourceManagerRespon
INNOCENT-BOY opened a new pull request, #10991:
URL: https://github.com/apache/pinot/pull/10991
Even though we enable case-insensitive，we found one potential risk in some
occasions. My two colleagues want to add one column to the same table in the
same pinot environment. But theirs naming s
saurabhd336 commented on code in PR #10969:
URL: https://github.com/apache/pinot/pull/10969#discussion_r1244781157
##
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##
@@ -3148,6 +3137,31 @@ public PinotResourceManagerRespon
saurabhd336 commented on code in PR #10969:
URL: https://github.com/apache/pinot/pull/10969#discussion_r1244779760
##
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotInstanceRestletResource.java:
##
@@ -390,4 +391,33 @@ public SuccessResponse update
79 matches
Mail list logo
