Jackie-Jiang commented on code in PR #10423:
URL: https://github.com/apache/pinot/pull/10423#discussion_r1245939233
##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DataTypeConversionFunctions.java:
##########
@@ -41,6 +41,9 @@ private DataTypeConversionFunctions() {
@ScalarFunction
public static Object cast(Object value, String targetTypeLiteral) {
+ if (value == null) {
Review Comment:
We shouldn't need to handle null here if the scalar function doesn't have
`nullableParameters`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
