wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1245956913
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegments(
}
}
+ @DELETE
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/segments/{tableName}/select")
+ @Authenticate(AccessType.DELETE)
+ @ApiOperation(value = "Delete select segments. An optional
'excludeReplacedSegments' parameter is used to get the"
+ + " list of segments which has not yet been replaced (determined by
segment lineage entries) and can be queried"
+ + " from the table. The value is false by default.",
+ // TODO: more and more filters can be added later on, like
excludeErrorSegments, excludeConsumingSegments, etc.
+ notes = "List all segments")
+ public SuccessResponse deleteSegmentsWithTimeWindow(
+ @ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
Review Comment:
If not specified, both realtime and offline parts will be deleted, which
make sense to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
