tibrewalpratik17 opened a new pull request, #10993:
URL: https://github.com/apache/pinot/pull/10993
labels:
1. `bugfix`
2. `backward-incompatible`
We found an issue with `listInstanceOrToggleTenantState` endpoint today in
our production.
- We do a POST operation in a API which is marked as GET. This leads to
confusion and treats this API as mainly a NOOP.
- We don't check if the state passed is a valid state in the list of enums -
ENABLE, DISABLE, DROP.
- If the state is not valid, we end-up disabling all the instances.
This led to ingestion and query failures in our production cluster.
This PR separates the POST operation in a separate POST API. Adds a check
for matching the state passed in the API parameter. Disables instances only
when `DISABLE` is passed as the State.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
