wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1245969155
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,47 @@ public SuccessResponse deleteSegments(
}
}
+ @DELETE
+ @Consumes(MediaType.APPLICATION_JSON)
+ @Produces(MediaType.APPLICATION_JSON)
+ @Path("/segments/{tableName}/select")
Review Comment:
There's an delete api to delete list of segments, but it's not user
friendly. Users need to use the get api with time window and then invoke the
deletion api. Moreover, the new delete api flip the default value of
excludeOverlapping (false -> true) and excludeReplacedSegments (true -> false)
of get api to cater with more intuitive deletion requirement. If the segment
min-max partially overlap with the give time window, the segments might contain
data out of given time window. Most of customers don't expect to delete those
data. Thus excludeOverlapping is set to true, meaning ignore segment that are
partially overlapped for deletion. For excludeReplacedSegments, the default
value is set to false, meaning completely delete segments regardless of the
replaced states.
@jtao15 do you have any objections?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
