[GitHub] [pinot] kishoreg commented on pull request #10700: [multistage] Add support for RANK and DENSE_RANK ranking window functions

kishoreg commented on PR #10700: URL: https://github.com/apache/pinot/pull/10700#issuecomment-1541417340 @siddharthteotia is this ready to get merged? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [pinot] KKcorps commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

KKcorps commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1189404582 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java: ## @@ -73,13 +75,15 @@ public abstract class BasePar

[GitHub] [pinot] KKcorps commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

KKcorps commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1189403848 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/immutable/ImmutableSegmentImpl.java: ## @@ -159,7 +159,11 @@ public void deleteValidDoc

[GitHub] [pinot] KKcorps commented on a diff in pull request #10047: Add upsert ttl configs for Pinot upsert optimizations

KKcorps commented on code in PR #10047: URL: https://github.com/apache/pinot/pull/10047#discussion_r1189400896 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java: ## @@ -181,6 +198,55 @@ protected void remo

[pinot] branch master updated: Add request id to the V2 broker response (#10706)

This is an automated email from the ASF dual-hosted git repository. kharekartik pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 4f5030530f Add request id to the V2 broker r

[GitHub] [pinot] KKcorps merged pull request #10706: Add request id to the V2 broker response

KKcorps merged PR #10706: URL: https://github.com/apache/pinot/pull/10706 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[pinot] branch master updated: [multistage] 10736: Fix for self join table names extraction in multistage (#10739)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git The following commit(s) were added to refs/heads/master by this push: new 6eeb9fb594 [multistage] 10736: Fix for self join t

[GitHub] [pinot] walterddr merged pull request #10739: [multistage] 10736: Fix for self join table names extraction in multistage

walterddr merged PR #10739: URL: https://github.com/apache/pinot/pull/10739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[GitHub] [pinot] JasonLeeWeiHern opened a new issue, #10753: Wrong error message for incorrect column name during lookup

JasonLeeWeiHern opened a new issue, #10753: URL: https://github.com/apache/pinot/issues/10753 Hi team, we believe that the error message could be more informative when sendin a query using the lookup on a dimension table. If we have an incorrect column name on the metric table in the

[GitHub] [pinot] mapshen commented on issue #7849: Inconsistent Row Counts from Upsert Tables

mapshen commented on issue #7849: URL: https://github.com/apache/pinot/issues/7849#issuecomment-1541187902 > Hi , it looks like a recent pr ([#16511](https://github.com/trinodb/trino/pull/16511)) for trino fixed `query1` , can you verify that a recent version of trino returns correct resul

[GitHub] [pinot] INNOCENT-BOY commented on pull request #10741: bugfix: add missing properties when edit instance config

INNOCENT-BOY commented on PR #10741: URL: https://github.com/apache/pinot/pull/10741#issuecomment-1541164858 Thanks @gortiz for your prompt review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [pinot] siddharthteotia commented on issue #10745: [multistage] The multistage aggregate planner and runtime do not work with all v1 aggregation functions

siddharthteotia commented on issue #10745: URL: https://github.com/apache/pinot/issues/10745#issuecomment-1541143669 FYI @kishoreg ^^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [pinot] siddharthteotia commented on issue #10745: [multistage] The multistage aggregate planner and runtime do not work with all v1 aggregation functions

siddharthteotia commented on issue #10745: URL: https://github.com/apache/pinot/issues/10745#issuecomment-1541143234 We sync'd up. @somandal will help with planner side changes and @vvivekiyer will help with runtime side changes. -- This is an automated message from the Apache Git Servi

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10739: [multistage] 10736: Fix for self join table names extraction in multistage

abhioncbr commented on code in PR #10739: URL: https://github.com/apache/pinot/pull/10739#discussion_r1189240441 ## pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java: ## @@ -3223,5 +3231,22 @@ public void testJoin() { Assert.assertEquals(ri

[GitHub] [pinot] npawar commented on a diff in pull request #10687: Implement mutable index using index SPI

npawar commented on code in PR #10687: URL: https://github.com/apache/pinot/pull/10687#discussion_r1189079489 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/MutableIndex.java: ## @@ -0,0 +1,48 @@ +/** + * Licensed to the Apache Software Foundation

[GitHub] [pinot] ankitsultana opened a new pull request, #10752: [Draft] Use Non-Random Path in Pinot Deepstore Upload Retry

ankitsultana opened a new pull request, #10752: URL: https://github.com/apache/pinot/pull/10752 TBD -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

[GitHub] [pinot] ankitsultana opened a new issue, #10751: Deepstore Upload Retry Task Uploads Segments to Paths Ending with UUID

ankitsultana opened a new issue, #10751: URL: https://github.com/apache/pinot/issues/10751 The deepstore upload retry task, which is enabled using: ``` controller.realtime.segment.deepStoreUploadRetryEnabled=true ``` Calls `/segments/{realtimeTableName}/{segmentName}/uploa

[GitHub] [pinot] siddharthteotia commented on issue #10658: [multistage] MV column support in Multi Stage

siddharthteotia commented on issue #10658: URL: https://github.com/apache/pinot/issues/10658#issuecomment-1540935231 Yes let's prioritize fixing the aggregation function work. @vvivekiyer and @jasperjiaguo will pick it up -- This is an automated message from the Apache Git Service. To r

[pinot] branch master updated (a9c97e3045 -> 53469c0b75)

This is an automated email from the ASF dual-hosted git repository. yupeng pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from a9c97e3045 Add description field to metrics in Pinot (#10744) add 53469c0b75 changing the dedup store to become pl

[GitHub] [pinot] yupeng9 merged pull request #10639: changing the dedup store to become pluggable

yupeng9 merged PR #10639: URL: https://github.com/apache/pinot/pull/10639 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apac

[GitHub] [pinot] yupeng9 commented on pull request #10639: changing the dedup store to become pluggable

yupeng9 commented on PR #10639: URL: https://github.com/apache/pinot/pull/10639#issuecomment-1540934693 @Jackie-Jiang I made a pass on the most recent change, and it looks good to me. Feel free to review this post-merge when you are back. -- This is an automated message from the Apache Gi

[GitHub] [pinot] siddharthteotia commented on issue #10745: [multistage] The multistage aggregate planner and runtime do not work with all v1 aggregation functions

siddharthteotia commented on issue #10745: URL: https://github.com/apache/pinot/issues/10745#issuecomment-1540933864 @vvivekiyer and @jasperjiaguo will be picking this up dividing the work between themselves for planner and runtime. -- This is an automated message from the Apache Gi

[GitHub] [pinot] shenyu0127 opened a new pull request, #10750: Make the TimeUnit in the DATETRUNC function case insensitive.

shenyu0127 opened a new pull request, #10750: URL: https://github.com/apache/pinot/pull/10750 https://github.com/apache/pinot/issues/10749 Tested: - Unit tests - Local server -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [pinot] walterddr merged pull request #10744: Add description field to metrics in Pinot

walterddr merged PR #10744: URL: https://github.com/apache/pinot/pull/10744 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[pinot] branch master updated (0a0ab995ee -> a9c97e3045)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 0a0ab995ee bug fix: add missing properties when edit instance config (#10741) add a9c97e3045 Add description field

[GitHub] [pinot] codecov-commenter commented on pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

codecov-commenter commented on PR #10746: URL: https://github.com/apache/pinot/pull/10746#issuecomment-1540856488 ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/10746?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache

[GitHub] [pinot] walterddr merged pull request #10741: bugfix: add missing properties when edit instance config

walterddr merged PR #10741: URL: https://github.com/apache/pinot/pull/10741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.ap

[pinot] branch master updated (7a673fd604 -> 0a0ab995ee)

This is an automated email from the ASF dual-hosted git repository. rongr pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/pinot.git from 7a673fd604 Support for ARG_MIN and ARG_MAX Functions (#10636) add 0a0ab995ee bug fix: add missing properties when e

[GitHub] [pinot] shenyu0127 opened a new issue, #10749: Case insensitive handling of timestamp related enums

shenyu0127 opened a new issue, #10749: URL: https://github.com/apache/pinot/issues/10749 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [pinot] navina commented on a diff in pull request #10744: Add description field to metrics in Pinot

navina commented on code in PR #10744: URL: https://github.com/apache/pinot/pull/10744#discussion_r1189048094 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -93,6 +93,10 @@ public PinotMetricsRegistry getMetricsRegistry() { public

[GitHub] [pinot] navina commented on pull request #10744: Add description field to metrics in Pinot

navina commented on PR #10744: URL: https://github.com/apache/pinot/pull/10744#issuecomment-1540771392 > Is auto documentation generation the primary motivation? (Not for this PR, general question) Is there a way to extract that field in our prometheus config files, so it can be used in our

[GitHub] [pinot] abhioncbr commented on pull request #10739: [multistage] 10736: Fix for self join table names extraction in multistage

abhioncbr commented on PR #10739: URL: https://github.com/apache/pinot/pull/10739#issuecomment-1540765910 Can we re-trigger the failing integration test? I am unsure, but I see intermittent failures in the integration test. Thanks -- This is an automated message from the Apache Git Se

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1189040919 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerAssignmentTest.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Ap

[GitHub] [pinot] npawar commented on a diff in pull request #9713: Extract headers for Kinesis Connector

npawar commented on code in PR #9713: URL: https://github.com/apache/pinot/pull/9713#discussion_r1189024860 ## pinot-plugins/pinot-stream-ingestion/pinot-kinesis/src/main/java/org/apache/pinot/plugin/stream/kinesis/KinesisMetadataExtractor.java: ## @@ -0,0 +1,44 @@ +/** + * Lice

[GitHub] [pinot] klsince commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

klsince commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1189019748 ## pinot-controller/src/test/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManagerAssignmentTest.java: ## @@ -0,0 +1,163 @@ +/** + * Licensed to the Apa

[GitHub] [pinot] xiangfu0 opened a new pull request, #10748: [WIP] refactor query planning phase

xiangfu0 opened a new pull request, #10748: URL: https://github.com/apache/pinot/pull/10748 Instructions: 1. The PR has to be tagged with at least one of the following labels (*): 1. `feature` 2. `bugfix` 3. `performance` 4. `ui` 5. `backward-incompat` 6

[GitHub] [pinot] walterddr commented on a diff in pull request #10744: Add description field to metrics in Pinot

walterddr commented on code in PR #10744: URL: https://github.com/apache/pinot/pull/10744#discussion_r1188964395 ## pinot-common/src/main/java/org/apache/pinot/common/metrics/AbstractMetrics.java: ## @@ -93,6 +93,10 @@ public PinotMetricsRegistry getMetricsRegistry() { publ

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188939540 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -2268,10 +2271,30 @@ public void assignTableSegment(Stri

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188939035 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TierConfigUtils.java: ## @@ -63,6 +67,32 @@ public static String getDataDirForTier(TableConfig tabl

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188939266 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/RealtimeSegmentAssignment.java: ## @@ -34,6 +34,8 @@ import org.apache.pin

[GitHub] [pinot] klsince commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

klsince commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188912139 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TierConfigUtils.java: ## @@ -63,6 +67,32 @@ public static String getDataDirForTier(TableConfig table

[GitHub] [pinot] walterddr commented on a diff in pull request #10739: [multistage] 10736: Fix for self join table names extraction in multistage

walterddr commented on code in PR #10739: URL: https://github.com/apache/pinot/pull/10739#discussion_r1188919302 ## pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java: ## @@ -3223,5 +3231,22 @@ public void testJoin() { Assert.assertEquals(ri

[GitHub] [pinot] walterddr closed issue #10688: [multistage] Pinot connection doesn't handle join routing parsing

walterddr closed issue #10688: [multistage] Pinot connection doesn't handle join routing parsing URL: https://github.com/apache/pinot/issues/10688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] klsince commented on a diff in pull request #10687: Implement mutable index using index SPI

klsince commented on code in PR #10687: URL: https://github.com/apache/pinot/pull/10687#discussion_r1188896344 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -287,111 +282,67 @@ public boolean isMutableSegm

[GitHub] [pinot] abhioncbr commented on issue #10688: [multistage] Pinot connection doesn't handle join routing parsing

abhioncbr commented on issue #10688: URL: https://github.com/apache/pinot/issues/10688#issuecomment-1540532246 We can close this issue. Thanks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [pinot] walterddr commented on a diff in pull request #10711: [multistage][cleanup] make leaf stage also registered with SchedulerService

walterddr commented on code in PR #10711: URL: https://github.com/apache/pinot/pull/10711#discussion_r1188874088 ## pinot-query-runtime/src/test/java/org/apache/pinot/query/runtime/executor/YieldingSchedulerServiceTest.java: ## @@ -41,7 +41,7 @@ import static org.mockito.Mockit

[GitHub] [pinot] walterddr commented on a diff in pull request #10711: [multistage][cleanup] make leaf stage also registered with SchedulerService

walterddr commented on code in PR #10711: URL: https://github.com/apache/pinot/pull/10711#discussion_r1188873743 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/LeafStageTransferableBlockOperator.java: ## @@ -93,27 +93,39 @@ public String toExplainSt

[GitHub] [pinot] walterddr commented on a diff in pull request #10711: [multistage][cleanup] make leaf stage also registered with SchedulerService

walterddr commented on code in PR #10711: URL: https://github.com/apache/pinot/pull/10711#discussion_r1188872327 ## pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/executor/LeafSchedulerService.java: ## @@ -0,0 +1,102 @@ +/** + * Licensed to the Apache Software

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188858089 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java: ## @@ -2268,10 +2271,28 @@ public void assignTableSegment(Stri

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188856998 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java: ## @@ -32,19 +32,63 @@ import org.apache.p

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188856103 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TierConfigUtils.java: ## @@ -63,6 +68,33 @@ public static String getDataDirForTier(TableConfig tabl

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188855224 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TierConfigUtils.java: ## @@ -63,6 +68,33 @@ public static String getDataDirForTier(TableConfig tabl

[GitHub] [pinot] abhioncbr commented on a diff in pull request #10739: [multistage] 10736: Fix for self join table names extraction in multistage

abhioncbr commented on code in PR #10739: URL: https://github.com/apache/pinot/pull/10739#discussion_r1188695827 ## pinot-common/src/test/java/org/apache/pinot/sql/parsers/CalciteSqlCompilerTest.java: ## @@ -3223,5 +3231,22 @@ public void testJoin() { Assert.assertEquals(ri

[GitHub] [pinot] abhioncbr commented on issue #10742: RFE: option to avoid exception when query timeout is reached

abhioncbr commented on issue #10742: URL: https://github.com/apache/pinot/issues/10742#issuecomment-1540186100 I see the following changes were implemented in the following [PR](https://github.com/apache/pinot/pull/7397). I also see in java-client, we can ignore the [exception](https://gith

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188473270 ## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java: ## @@ -32,19 +32,63 @@ import org.apache.p

[GitHub] [pinot] sylph-eu commented on a diff in pull request #10746: [feature] Consider tierConfigs when assigning new offline segment

sylph-eu commented on code in PR #10746: URL: https://github.com/apache/pinot/pull/10746#discussion_r1188470490 ## pinot-common/src/main/java/org/apache/pinot/common/utils/config/TierConfigUtils.java: ## @@ -63,6 +68,33 @@ public static String getDataDirForTier(TableConfig tabl

[GitHub] [pinot] gortiz commented on a diff in pull request #10687: Implement mutable index using index SPI

gortiz commented on code in PR #10687: URL: https://github.com/apache/pinot/pull/10687#discussion_r1188353553 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/provider/MutableIndexContext.java: ## @@ -18,36 +18,97 @@ */ package org.apache.pinot.se

[GitHub] [pinot] kishoreg commented on issue #10658: [multistage] MV column support in Multi Stage

kishoreg commented on issue #10658: URL: https://github.com/apache/pinot/issues/10658#issuecomment-1539721298 this is probably not needed if we implement the idea described here - https://github.com/apache/pinot/issues/10745 right? -- This is an automated message from the Apache Git Servi

[GitHub] [pinot] gortiz commented on pull request #10687: Implement mutable index using index SPI

gortiz commented on PR #10687: URL: https://github.com/apache/pinot/pull/10687#issuecomment-1539687184 Is there something else we need to modify here? or can we merge it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [pinot] gortiz commented on a diff in pull request #10687: Implement mutable index using index SPI

gortiz commented on code in PR #10687: URL: https://github.com/apache/pinot/pull/10687#discussion_r1188308217 ## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/indexsegment/mutable/MutableSegmentImpl.java: ## @@ -287,111 +282,67 @@ public boolean isMutableSegme

[GitHub] [pinot] gortiz commented on a diff in pull request #10687: Implement mutable index using index SPI

gortiz commented on code in PR #10687: URL: https://github.com/apache/pinot/pull/10687#discussion_r1188295331 ## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/provider/MutableIndexContext.java: ## @@ -18,36 +18,97 @@ */ package org.apache.pinot.se

[GitHub] [pinot] siddharthteotia commented on pull request #10636: Support for ARG_MIN and ARG_MAX Functions

siddharthteotia commented on PR #10636: URL: https://github.com/apache/pinot/pull/10636#issuecomment-1539650886 @jasperjiaguo please add user docs soon. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [pinot] kishoreg commented on issue #10745: [multistage] The multistage aggregate planner and runtime do not work with all v1 aggregation functions

kishoreg commented on issue #10745: URL: https://github.com/apache/pinot/issues/10745#issuecomment-1539611189 Thanks @somandal for summarizing. I forgot to bring up the issue with the return data type for aggregation functions. we should enhance the aggregation function to have a meth

[GitHub] [pinot] siddharthteotia merged pull request #10636: Support for ARG_MIN and ARG_MAX Functions

siddharthteotia merged PR #10636: URL: https://github.com/apache/pinot/pull/10636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pi

[GitHub] [pinot] siddharthteotia commented on pull request #10636: Support for ARG_MIN and ARG_MAX Functions

siddharthteotia commented on PR #10636: URL: https://github.com/apache/pinot/pull/10636#issuecomment-1539606315 I have some suggestions / questions on simplifying the implementation a bit. But don't want to hold this. Let's discuss them sometime soon. -- This is an automated message from

[GitHub] [pinot] siddharthteotia commented on a diff in pull request #10636: Support for ARG_MIN and ARG_MAX Functions

siddharthteotia commented on code in PR #10636: URL: https://github.com/apache/pinot/pull/10636#discussion_r1188230046 ## pinot-core/src/main/java/org/apache/pinot/core/query/aggregation/function/ChildAggregationFunction.java: ## @@ -0,0 +1,160 @@ +/** + * Licensed to the Apache