[GitHub] [pinot] kishoreg commented on issue #10745: [multistage] The multistage aggregate planner and runtime do not work with all v1 aggregation functions

[via GitHub]

kishoreg commented on issue #10745:
URL: https://github.com/apache/pinot/issues/10745#issuecomment-1539611189

   Thanks @somandal for summarizing. I forgot to bring up the issue with the 
return data type for aggregation functions.
   
   we should enhance the aggregation function to have a method that provides 
the result data type based on the input type.
   
   ```  
     ColumnDataType getIntermediateResultColumnType();
   
     ColumnDataType getFinalResultColumnType();
      
   /** new method*/
     default ColumnDataType getIntermediateResultColumnType(ColumnDataType[] 
argTypes){
       return getIntermediateResultColumnType();
     }
   
     
    /** new method*/
     default ColumnDataType getFinalResultColumnType(ColumnDataType[] argTypes){
       return getFinalResultColumnType();
     }
     ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org