sylph-eu commented on code in PR #10746:
URL: https://github.com/apache/pinot/pull/10746#discussion_r1188939035
##########
pinot-common/src/main/java/org/apache/pinot/common/utils/config/TierConfigUtils.java:
##########
@@ -63,6 +67,32 @@ public static String getDataDirForTier(TableConfig
tableConfig, String tierName)
return getDataDirForTier(tableConfig, tierName, Collections.emptyMap());
}
+ /**
+ * Consider configured tiers and compute default instance partitions for the
segment
+ *
+ * @return InstancePartitions if the one can be derived from the given
sorted tiers, null otherwise
+ */
+ @Nullable
+ public static InstancePartitions
getTieredInstancePartitionsForSegment(String tableNameWithType,
+ @Nullable List<Tier> sortedTiers, String segmentName, HelixManager
helixManager) {
Review Comment:
Fixed.
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/OfflineSegmentAssignment.java:
##########
@@ -32,16 +32,20 @@
import
org.apache.pinot.controller.helix.core.assignment.segment.strategy.SegmentAssignmentStrategyFactory;
import org.apache.pinot.spi.config.table.assignment.InstancePartitionsType;
import org.apache.pinot.spi.utils.RebalanceConfigConstants;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
/**
* Segment assignment for offline table.
*/
public class OfflineSegmentAssignment extends BaseSegmentAssignment {
+ private final Logger _logger = LoggerFactory.getLogger(getClass());
Review Comment:
Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
