gortiz commented on code in PR #10687: URL: https://github.com/apache/pinot/pull/10687#discussion_r1188353553
########## pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/mutable/provider/MutableIndexContext.java: ########## @@ -18,36 +18,97 @@ */ package org.apache.pinot.segment.spi.index.mutable.provider; +import java.io.File; import java.util.Objects; +import javax.annotation.Nullable; import org.apache.pinot.segment.spi.memory.PinotDataBufferMemoryManager; -import org.apache.pinot.spi.config.table.JsonIndexConfig; import org.apache.pinot.spi.data.FieldSpec; -public interface MutableIndexContext { - PinotDataBufferMemoryManager getMemoryManager(); +public class MutableIndexContext { Review Comment: Oh, sorry, I thought you mean to change MutableIndexContext from interface to class. I didn't touch `IndexCreationContext`. In case we change it, it should be done in another PR -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org