KKcorps commented on code in PR #10047:
URL: https://github.com/apache/pinot/pull/10047#discussion_r1189404582
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -73,13 +75,15 @@ public abstract class BasePartitionUpsertMetadataManager
implements PartitionUps
protected BasePartitionUpsertMetadataManager(String tableNameWithType, int
partitionId,
List<String> primaryKeyColumns, List<String> comparisonColumns,
HashFunction hashFunction,
- @Nullable PartialUpsertHandler partialUpsertHandler, boolean
enableSnapshot, ServerMetrics serverMetrics) {
+ @Nullable PartialUpsertHandler partialUpsertHandler, @Nullable
UpsertTTLConfig upsertTTLConfig,
Review Comment:
We are cramming too many args in this constructor. Should directly pass
upsert config here. If out of scope for this PR, please create another issue
for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
